Bug 137556 - [EFL] m_soupRequestManager was not declared
Summary: [EFL] m_soupRequestManager was not declared
Status: CLOSED DUPLICATE of bug 137613
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 05:49 PDT by KwangHyuk
Modified: 2014-10-10 10:36 PDT (History)
2 users (show)

See Also:

Attachments
Fix build break casued by undeclared variable m_soupRequestManager. (1.56 KB, patch)
2014-10-09 05:59 PDT, KwangHyuk 		cdumez: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KwangHyuk 2014-10-09 05:49:29 PDT 
There is compilation error caused by undeclared variable for the webkit efl debug build.

/home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp: In constructor ‘WebKit::RequestManagerClientEfl::RequestManagerClientEfl(WKContextRef)’:
/home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp:42:12: error: ‘m_soupRequestManager’ was not declared in this scope
     ASSERT(m_soupRequestManager);
            ^
/home/hyuki/git/webkit2/Source/WTF/wtf/Assertions.h:232:8: note: in definition of macro ‘ASSERT’
     (!(assertion) ? \
        ^
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/ViewClientEfl.cpp.o
[ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/WebColorPickerClient.cpp.o
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/RequestManagerClientEfl.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
Comment 1 KwangHyuk 2014-10-09 05:59:24 PDT 
Created attachment 239530 [details]
Fix build break casued by undeclared variable m_soupRequestManager.
Comment 2 Chris Dumez 2014-10-10 10:22:53 PDT 
Comment on attachment 239530 [details]
Fix build break casued by undeclared variable m_soupRequestManager.

https://bugs.webkit.org/show_bug.cgi?id=137613 seems like a better fix.
Comment 3 KwangHyuk 2014-10-10 10:33:14 PDT 
(In reply to comment #2)
> (From update of attachment 239530 [details])
> https://bugs.webkit.org/show_bug.cgi?id=137613 seems like a better fix.

Thx for your review. :)
Agree with you. So, close this bug.
Comment 4 KwangHyuk 2014-10-10 10:34:11 PDT 

*** This bug has been marked as a duplicate of bug 137613 ***