WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED DUPLICATE of
bug 137613
137556
[EFL] m_soupRequestManager was not declared
https://bugs.webkit.org/show_bug.cgi?id=137556
Summary
[EFL] m_soupRequestManager was not declared
KwangHyuk
Reported
2014-10-09 05:49:29 PDT
There is compilation error caused by undeclared variable for the webkit efl debug build. /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp: In constructor ‘WebKit::RequestManagerClientEfl::RequestManagerClientEfl(WKContextRef)’: /home/hyuki/git/webkit2/Source/WebKit2/UIProcess/efl/RequestManagerClientEfl.cpp:42:12: error: ‘m_soupRequestManager’ was not declared in this scope ASSERT(m_soupRequestManager); ^ /home/hyuki/git/webkit2/Source/WTF/wtf/Assertions.h:232:8: note: in definition of macro ‘ASSERT’ (!(assertion) ? \ ^ [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/ViewClientEfl.cpp.o [ 95%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/WebColorPickerClient.cpp.o make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/efl/RequestManagerClientEfl.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
Attachments
Fix build break casued by undeclared variable m_soupRequestManager.
(1.56 KB, patch)
2014-10-09 05:59 PDT
,
KwangHyuk
cdumez
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
KwangHyuk
Comment 1
2014-10-09 05:59:24 PDT
Created
attachment 239530
[details]
Fix build break casued by undeclared variable m_soupRequestManager.
Chris Dumez
Comment 2
2014-10-10 10:22:53 PDT
Comment on
attachment 239530
[details]
Fix build break casued by undeclared variable m_soupRequestManager.
https://bugs.webkit.org/show_bug.cgi?id=137613
seems like a better fix.
KwangHyuk
Comment 3
2014-10-10 10:33:14 PDT
(In reply to
comment #2
)
> (From update of
attachment 239530
[details]
) >
https://bugs.webkit.org/show_bug.cgi?id=137613
seems like a better fix.
Thx for your review. :) Agree with you. So, close this bug.
KwangHyuk
Comment 4
2014-10-10 10:34:11 PDT
*** This bug has been marked as a duplicate of
bug 137613
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug