Bug 137551 - [iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData
Summary: [iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-09 00:16 PDT by Andy Estes
Modified: 2014-10-09 11:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2014-10-09 00:19 PDT, Andy Estes 		ddkilzer: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2014-10-09 00:16:08 PDT 
[iOS] Crash in CFURLDownloadClient.didFail if the download has a null resumeData
Comment 1 Andy Estes 2014-10-09 00:19:18 PDT 
Created attachment 239522 [details]
Patch
Comment 2 Andy Estes 2014-10-09 00:19:49 PDT 
rdar://problem/17316756
Comment 3 David Kilzer (:ddkilzer) 2014-10-09 02:43:13 PDT 
Comment on attachment 239522 [details]
Patch

r=me
Comment 4 Alexey Proskuryakov 2014-10-09 10:56:02 PDT 
Do we have steps to reproduce? Does this happen with all servers that don't support resuming?
Comment 5 Andy Estes 2014-10-09 11:08:21 PDT 
(In reply to comment #4)
> Do we have steps to reproduce?

No, this is a speculative fix based on looking at crash reports.

> Does this happen with all servers that don't support resuming?

I don't know how to answer that question. I know that CFURLDownloadCopyResumeData() can return null and that we should handle it (this patch aligns our behavior with that of the Mac; e.g. passing a 0-length DataReference to DownloadProxy::didFail).
Comment 6 Andy Estes 2014-10-09 11:16:25 PDT 
Committed r174512: <http://trac.webkit.org/changeset/174512>