Bug 137547 - Web Inspector: DOM Storage Editing is broken in many ways, frustrating
Summary: Web Inspector: DOM Storage Editing is broken in many ways, frustrating
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-08 20:34 PDT by Joseph Pecoraro
Modified: 2014-10-09 10:34 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (12.15 KB, patch)
2014-10-08 20:38 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-10-08 20:34:40 PDT 
DOM Storage editing is broken in many ways.

* STEPS TO REPRODUCE
1. Load <http://bogojoker.com>
2. Start adding keys / values to local storage
3. Start editing existing keys / values
4. Right click a row
  => exception in console
5. Double click a value, change it, and hit Enter to commit the change
  => value is still editable
6. Edit a key to be a duplicate of another key, then change to a new value
  => non-edited row that was temporarily a duplicate is now gone
Comment 1 Radar WebKit Bug Importer 2014-10-08 20:34:49 PDT 
<rdar://problem/18592458>
Comment 2 Joseph Pecoraro 2014-10-08 20:38:37 PDT 
Created attachment 239514 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2014-10-09 09:56:45 PDT 
Comment on attachment 239514 [details]
[PATCH] Proposed Fix

Much cleaner!
Comment 4 WebKit Commit Bot 2014-10-09 10:34:08 PDT 
Comment on attachment 239514 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 239514

Committed r174510: <http://trac.webkit.org/changeset/174510>
Comment 5 WebKit Commit Bot 2014-10-09 10:34:11 PDT 
All reviewed patches have been landed.  Closing bug.