Bug 137533 – MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ada Chan]

When new audio/video tracks are parsed in SourceBufferPrivateAVFObjC, I would expect MediaPlayer::characteristicsChanged() to be called since the media's characteristics (such as hasAudio, hasVideo) have changed.

1. Open a youtube video page showing HTML5 video.
2. Place a breakpoint in MediaPlayer::characteristicsChanged().

RESULTS: I don't see that called due to a change in hasAudio/hasVideo characteristics.

[Jer Noble]

Created attachment 239491 [details]
Patch

[Darin Adler]

Comment on attachment 239491 [details]
Patch

No regression test possible?

[Jer Noble]

(In reply to comment #2)
> (From update of attachment 239491 [details])
> No regression test possible?

A TestWebKitAPI unit test should be possible.  I'm working on one now.

[Jer Noble]

Created attachment 239668 [details]
Patch for landing

[Jer Noble]

Created attachment 239680 [details]
Patch

Also unregister for availability changes when the page is hidden (e.g., when in a background tab).

[Jer Noble]

Created attachment 239701 [details]
Patch

[Eric Carlson]

(In reply to comment #6)
> Created an attachment (id=239701) [details]
> Patch

I think you meant to attach this to bug 137633.

[Jer Noble]

Committed r174652: <http://trac.webkit.org/changeset/174652>

[Andy Estes]

Looks like the new API test is timing out on both the Mavericks and Mountain Lion bots. For example:

https://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29/builds/8217/steps/run-api-tests/logs/stdio

[Jer Noble]

Oof. MSE is only enabled on Yosemite.

[Jer Noble]

Reopening to attach new patch.

[Jer Noble]

Created attachment 239744 [details]
Follow up patch

[Andy Estes]

Comment on attachment 239744 [details]
Follow up patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239744&action=review

> Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:58
> +    EXPECT_TRUE(JSValueIsBoolean(scriptContext, resultValue));

Won't this cause the test to fail on unsupported platforms?

[Andy Estes]

Comment on attachment 239744 [details]
Follow up patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239744&action=review

>> Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:58
>> +    EXPECT_TRUE(JSValueIsBoolean(scriptContext, resultValue));
> 
> Won't this cause the test to fail on unsupported platforms?

Oh never mind. Sigh. IsBoolean != ToBoolean.

[WebKit Commit Bot]

Comment on attachment 239744 [details]
Follow up patch

Clearing flags on attachment: 239744

Committed r174667: <http://trac.webkit.org/changeset/174667>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jer Noble]

<rdar://problem/19269053>