Bug 137529 - [Win] Crashing in inspector-protocol tests
Summary: [Win] Crashing in inspector-protocol tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Major
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-08 10:50 PDT by Brent Fulgham
Modified: 2017-01-18 23:39 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-10-08 10:50:09 PDT
We are experiencing two inspector-protocol failures:

inspector-protocol/debugger/terminate-dedicated-worker-while-paused.html
inspector-protocol/debugger/pause-on-assert.html

It appears that the inspector is getting disconnected from the worker process before all messages have been processed. When this happens, we attempt to dereference a null pointer and the process crashes:

Call stack:
>	WebKit.dll!WebCore::WorkerMessagingProxy::postMessageToPageInspector::__l3::<lambda>(WebCore::ScriptExecutionContext & __formal) Line 299	C++
 	[External Code]	
 	WebKit.dll!WebCore::ScriptExecutionContext::Task::performTask(WebCore::ScriptExecutionContext & context) Line 144	C++
 	WebKit.dll!WebCore::Document::postTask::__l8::<lambda>() Line 5012	C++
 	[External Code]	
 	WTF.dll!WTF::callFunctionObject(void * context) Line 213	C++
 	WTF.dll!WTF::dispatchFunctionsFromMainThread() Line 165	C++
 	WTF.dll!WTF::ThreadingWindowWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam) Line 47	C++
 	[External Code]	
 	DumpRenderTree.dll!runTest(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & inputLine) Line 1095	C++
 	DumpRenderTree.dll!main(int argc, const char * * argv) Line 1383	C++
 	DumpRenderTree.dll!dllLauncherEntryPoint(int argc, const char * * argv) Line 1408	C++
 	DumpRenderTree.exe!main(int argc, const char * * argv) Line 235	C++
 	[External Code]	

m_pageInspector is 0, because WorkerMessagingProxy::disconnectFromInspector was called before the worker runloop was empty of messages for the inspector.
Comment 1 Brent Fulgham 2014-10-08 15:12:12 PDT
These two tests were marked as crashing in r174479. <https://trac.webkit.org/r174479>.
Comment 2 Radar WebKit Bug Importer 2014-10-08 15:12:43 PDT
<rdar://problem/18588536>