If a test times out, webkitpy will kill the LayoutTestRelay. However, the signal isn't forwarded to the underlying DRT/WKTR. This used to not be a problem because when LayoutTestRelay gets launched with the same arguments, launching the same app identifier in the simulator would first quit the old instance. That's no longer the case and the same DRT/WKTR instance will be sitting there still timing out. So, we need to catch a signal and kill the simulator app before dying so that it can be properly relaunched when a timeout->kill happens.
Created attachment 239661 [details]
Comment on attachment 239661 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=239661&action=review
> + NSLog(@"FINISHING");
I don't think you want this.
> + os.kill(pid, signal.SIGTERM)
This needs a comment I think.
Committed r174628: <http://trac.webkit.org/changeset/174628>
(In reply to comment #3)
> Committed r174628: <http://trac.webkit.org/changeset/174628>
It broke the related webkitpy unittest. Could you update its expected result?
This broke a python test.
I fixed this in r174634.