Bug 137527 – [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Farler]

If the LayoutTestRelay receives an EOF from the test harness, it should do the following:

- make sure that it gets properly forwarded to DRT/WKTR. The only question is - does DRT/WKTR as an iOS app "exit 0" when it receives the EOF and exits the "test server loop"?
- exit 0

[David Farler]

Created attachment 239650 [details]
Patch

[WebKit Commit Bot]

Attachment 239650 [details] did not pass style-queue:


ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:72:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:72:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Farler]

(In reply to comment #2)
> Attachment 239650 [details] did not pass style-queue:
> 
> 
> ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:72:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
> ERROR: Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:72:  Extra space before ( in function call  [whitespace/parens] [4]
> Total errors found: 2 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Already filed a bug for this (Objective-C exceptions treated like functions). Thanks anyway, style bot.

[Simon Fraser (smfr)]

Comment on attachment 239650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239650&action=review

> Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:71
> +                    NSData *data = [NSData dataWithBytes:buffer length:len];
> +                    [[[self relay] outputStream] write:[data bytes] maxLength:[data length]];

Why make an NSData just to hand off the bytes directly?

[David Farler]

(In reply to comment #4)
> (From update of attachment 239650 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239650&action=review
> 
> > Tools/LayoutTestRelay/LayoutTestRelay/LTRelayController.m:71
> > +                    NSData *data = [NSData dataWithBytes:buffer length:len];
> > +                    [[[self relay] outputStream] write:[data bytes] maxLength:[data length]];
> 
> Why make an NSData just to hand off the bytes directly?

Oh. For some reason I just had it in my mind that I needed to do that from a different API a long time ago. I'll forward the bytes on directly. I'll have another patch in just a minute.

[David Farler]

Committed r174626: <http://trac.webkit.org/changeset/174626>