Bug 137525 - REGRESSION (r174402): media/track/track-forced-subtitles-in-band.html fails
Summary: REGRESSION (r174402): media/track/track-forced-subtitles-in-band.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on: 137472
Blocks: 137505
  Show dependency treegraph
 
Reported: 2014-10-08 10:10 PDT by Andy Estes
Modified: 2014-10-20 22:54 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2014-10-08 10:10:16 PDT
After r174403, media/track/track-forced-subtitles-in-band.html has started failing on the Mac wk1 and wk2 test bots like so:

--- /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/media/track/track-forced-subtitles-in-band-expected.txt
+++ /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/media/track/track-forced-subtitles-in-band-actual.txt
@@ -10,7 +10,7 @@
 
 ** Forced tracks should be in .textTracks, but not in the menu
 EXPECTED (video.textTracks.length == '9') OK
-EXPECTED (trackMenuItems.length == '6') OK
+EXPECTED (trackMenuItems.length == '6'), OBSERVED '3' FAIL
 
 ** Only the 'fr' forced track should be showing
 EXPECTED (video.textTracks[0].language == 'en') OK

See https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r174451%20(8513)/results.html for more details.
Comment 1 Andy Estes 2014-10-08 10:16:46 PDT
Updated TestExpectations in r174458: <http://trac.webkit.org/changeset/174458>
Comment 2 Chris Dumez 2014-10-08 10:20:48 PDT
Ok, I'll take a look thanks
Comment 3 Andy Estes 2014-10-08 10:21:34 PDT
r174402 is the culprit, not r174403. Off-by-one error on my part :)
Comment 4 Alexey Proskuryakov 2014-10-20 20:11:24 PDT
This text has stopped failing on the next day, and is "only" flaky once again.

Jer, do you know what fixed this? Could it be <http://trac.webkit.org/changeset/174460>?
Comment 5 Jer Noble 2014-10-20 20:29:11 PDT
(In reply to comment #4)
> This text has stopped failing on the next day, and is "only" flaky once
> again.
> 
> Jer, do you know what fixed this? Could it be
> <http://trac.webkit.org/changeset/174460>?

No, it was probably <http://trac.webkit.org/changeset/174472>.
Comment 6 Alexey Proskuryakov 2014-10-20 22:54:31 PDT
Indeed - there was a large gap in coverage, so I didn't see that at first. Historical data agrees with r174472 being the fix.

So, the fix for the "test is flaky" bug addressed it failing every time, but did not address the flakiness.