Bug 137525 – REGRESSION (r174402): media/track/track-forced-subtitles-in-band.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Andy Estes]

After r174403, media/track/track-forced-subtitles-in-band.html has started failing on the Mac wk1 and wk2 test bots like so:

--- /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/media/track/track-forced-subtitles-in-band-expected.txt
+++ /Volumes/Data/slave/mavericks-release-tests-wk2/build/layout-test-results/media/track/track-forced-subtitles-in-band-actual.txt
@@ -10,7 +10,7 @@
 
 ** Forced tracks should be in .textTracks, but not in the menu
 EXPECTED (video.textTracks.length == '9') OK
-EXPECTED (trackMenuItems.length == '6') OK
+EXPECTED (trackMenuItems.length == '6'), OBSERVED '3' FAIL
 
 ** Only the 'fr' forced track should be showing
 EXPECTED (video.textTracks[0].language == 'en') OK

See https://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r174451%20(8513)/results.html for more details.

[Andy Estes]

Updated TestExpectations in r174458: <http://trac.webkit.org/changeset/174458>

[Chris Dumez]

Ok, I'll take a look thanks

[Andy Estes]

r174402 is the culprit, not r174403. Off-by-one error on my part :)

[Alexey Proskuryakov]

This text has stopped failing on the next day, and is "only" flaky once again.

Jer, do you know what fixed this? Could it be <http://trac.webkit.org/changeset/174460>?

[Jer Noble]

(In reply to comment #4)
> This text has stopped failing on the next day, and is "only" flaky once
> again.
> 
> Jer, do you know what fixed this? Could it be
> <http://trac.webkit.org/changeset/174460>?

No, it was probably <http://trac.webkit.org/changeset/174472>.

[Alexey Proskuryakov]

Indeed - there was a large gap in coverage, so I didn't see that at first. Historical data agrees with r174472 being the fix.

So, the fix for the "test is flaky" bug addressed it failing every time, but did not address the flakiness.