Bug 137516 - [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
Summary: [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-08 02:46 PDT by Csaba Osztrogonác
Modified: 2014-10-08 10:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2014-10-08 02:46 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-10-08 02:46:09 PDT 
[webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
Comment 1 Csaba Osztrogonác 2014-10-08 02:46:18 PDT 
Created attachment 239463 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-10-08 02:49:57 PDT 
ZipFile.extractall() in python is still buggy:
https://bugs.webkit.org/show_bug.cgi?id=137338#c13

We should add back its workaround, of course. But why 
not use the bug free tar.gz if it works out of the box?
Comment 3 Csaba Osztrogonác 2014-10-08 08:50:26 PDT 
( The workaround was added back in http://trac.webkit.org/changeset/174448. )
Comment 4 WebKit Commit Bot 2014-10-08 10:40:11 PDT 
Comment on attachment 239463 [details]
Patch

Clearing flags on attachment: 239463

Committed r174461: <http://trac.webkit.org/changeset/174461>
Comment 5 WebKit Commit Bot 2014-10-08 10:40:15 PDT 
All reviewed patches have been landed.  Closing bug.