Bug 137511 – [CoordinatedGraphics] Flickering bug of a translate animation when used with percentage value and webkit-transition-duration

• Status: NEW
• Component: WebKit EFL

[June Geol Kim]

Created attachment 239452 [details]
Test case

It occurs when used -webkit-transform::translate(x,y) and -webkit-transition-duration together.
And another main condition is that its transform value is only percentage.

Example below
  -webkit-transform:translate(50%,0);
  -webkit-transition-duration: 1s;

The testcase is attached and I found the web page having this problem at http://m.daum.net.

You can test it with the attached test case on PC or the URL with this problem is http://m.daum.net on a mobile phone.

[June Geol Kim]

Created attachment 239456 [details]
Patch : the cause of this bug is an overflow when converting from float to integer.

I found that the cause of this bug is an overflow when converting from float to integer.
The GraphicsLayerAnimation's boxSize is encoded to FloatSize but is decoded to IntSize In the CoordinatedGraphics' ArgumentCoder.

As a result, it is translated to the unexpected position and might be seen like flickering.

[Ryuan Choi]

Comment on attachment 239456 [details]
Patch : the cause of this bug is an overflow when converting from float to integer.

Next time, please check r? if you want to get review.

[Darin Adler]

Comment on attachment 239456 [details]
Patch : the cause of this bug is an overflow when converting from float to integer.

Bug fix looks fine. Needs a ChangeLog and, if possible, a test case. review- because of no ChangeLog.

[June Geol Kim]

Created attachment 239930 [details]
ChangeLog

I'm sorry. 
I've attached a ChangeLog.
 
Darin, Thank you for your review!!

[WebKit Commit Bot]

Attachment 239930 [details] did not pass style-queue:


Total errors found: 0 in 0 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[June Geol Kim]

Created attachment 239932 [details]
patch

Sorry. the previous ChangeLog was wrong.
So I've attached new ChangeLog.

This is the first commit of mine.
Next time I will not make a mistake.

[Gyuyoung Kim]

Comment on attachment 239932 [details]
patch

First of all, thank you for uploading your patch regarding coordinated graphics. However, it looks you uploaded your patch without any webkit contribution experience. I think you uploaded your patch with wrong file format type and no-patch checking option. Please read below guide before uploading your patch.


http://www.webkit.org/coding/contributing.html

r- because of wrong changelog update.

[June Geol Kim]

Created attachment 239937 [details]
patch

I'm sorry. 
I've read your sent contributing code page and checked it one more time.
I think a wrong file format(application/octet-stream) was because I didn't select a patch for Content Type.
I've selected it and try to upload it.

[Gyuyoung Kim]

Comment on attachment 239937 [details]
patch

Your patch updated ChangeLog file totally even though you only touch WebKit2. Remove many changes in ChangeLog file. Contributor should check patch before uploading to Bugzilla.

One more thing. isn't there any test case which can be fixed by this fix ?

[Ryuan Choi]

june geol,

Can you update this?

I think that this bug is still vaild.