see https://bugs.webkit.org/show_bug.cgi?id=137460
Created attachment 239435 [details] Adds the PatchIsNotValid throw to StyleQueue
Comment on attachment 239435 [details] Adds the PatchIsNotValid throw to StyleQueue Don't we need to also remove an existing validate() call from StyleQueue?
Created attachment 239507 [details] Removes the redundant validate call from StyleQueue
Comment on attachment 239507 [details] Removes the redundant validate call from StyleQueue View in context: https://bugs.webkit.org/attachment.cgi?id=239507&action=review > Tools/Scripts/webkitpy/tool/commands/queues.py:327 > + return False I wonder if we should stop returning values from process_work_item; the caller doesn't do anything meaningful with them. > Tools/Scripts/webkitpy/tool/commands/queues.py:467 > + return False And maybe ones in review_patch functions too. It's quite confusing that each subclass is responsible to all results except for _did_pass, it seems better to make them call _did_pass, too.
Comment on attachment 239507 [details] Removes the redundant validate call from StyleQueue Clearing flags on attachment: 239507 Committed r174501: <http://trac.webkit.org/changeset/174501>
All reviewed patches have been landed. Closing bug.