Bug 137500 - StyleQueue should throw a PatchIsNotValid exception to achieve consistency with CommitQueue and EWS
Summary: StyleQueue should throw a PatchIsNotValid exception to achieve consistency wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jake Nielsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-07 14:36 PDT by Jake Nielsen
Modified: 2014-10-08 23:50 PDT (History)
3 users (show)

See Also:


Attachments
Adds the PatchIsNotValid throw to StyleQueue (5.42 KB, patch)
2014-10-07 14:52 PDT, Jake Nielsen
no flags Details | Formatted Diff | Diff
Removes the redundant validate call from StyleQueue (5.82 KB, patch)
2014-10-08 17:47 PDT, Jake Nielsen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Nielsen 2014-10-07 14:36:21 PDT
see https://bugs.webkit.org/show_bug.cgi?id=137460
Comment 1 Jake Nielsen 2014-10-07 14:52:39 PDT
Created attachment 239435 [details]
Adds the PatchIsNotValid throw to StyleQueue
Comment 2 Alexey Proskuryakov 2014-10-07 14:57:16 PDT
Comment on attachment 239435 [details]
Adds the PatchIsNotValid throw to StyleQueue

Don't we need to also remove an existing validate() call from StyleQueue?
Comment 3 Jake Nielsen 2014-10-08 17:47:15 PDT
Created attachment 239507 [details]
Removes the redundant validate call from StyleQueue
Comment 4 Alexey Proskuryakov 2014-10-08 23:13:21 PDT
Comment on attachment 239507 [details]
Removes the redundant validate call from StyleQueue

View in context: https://bugs.webkit.org/attachment.cgi?id=239507&action=review

> Tools/Scripts/webkitpy/tool/commands/queues.py:327
> +            return False

I wonder if we should stop returning values from process_work_item; the caller doesn't do anything meaningful with them.

> Tools/Scripts/webkitpy/tool/commands/queues.py:467
> +            return False

And maybe ones in review_patch functions too. It's quite confusing that each subclass is responsible to all results except for _did_pass, it seems better to make them call _did_pass, too.
Comment 5 WebKit Commit Bot 2014-10-08 23:50:52 PDT
Comment on attachment 239507 [details]
Removes the redundant validate call from StyleQueue

Clearing flags on attachment: 239507

Committed r174501: <http://trac.webkit.org/changeset/174501>
Comment 6 WebKit Commit Bot 2014-10-08 23:50:54 PDT
All reviewed patches have been landed.  Closing bug.