Bug 137463 – Text drawn with an SVG font has no spaces when word-rounding hacks are enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Text drawn with an SVG font has no spaces when word-rounding hacks are enabled

[Myles C. Maxfield]

Created attachment 239364 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/18506282>

[Build Bot]

Comment on attachment 239364 [details]
Patch

Attachment 239364 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4849734556581888

New failing tests:
fast/text/svg-font-word-rounding-hacks-spaces.html

[Build Bot]

Created attachment 239368 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 239364 [details]
Patch

Attachment 239364 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5961705079177216

New failing tests:
fast/text/svg-font-word-rounding-hacks-spaces.html

[Build Bot]

Created attachment 239371 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Myles C. Maxfield]

Created attachment 239433 [details]
Patch

[Andrei Bucur]

Comment on attachment 239433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239433&action=review

> Source/WebCore/svg/SVGFontData.cpp:111
> +    fontData->setSpaceWidth(spaceWidth);

Should't setAdjustedSpaceWidth(0) be called in the if (!glyphPageZero) above, especially if it's initialized with undefined?

[Darin Adler]

Comment on attachment 239433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239433&action=review

> Source/WebCore/platform/graphics/SimpleFontData.h:163
>      void setSpaceWidth(float spaceWidth) { m_spaceWidth = spaceWidth; }
> +    void setAdjustedSpaceWidth(float adjustedSpaceWidth) { m_adjustedSpaceWidth = adjustedSpaceWidth; }

Maybe we should offer a setter that sets both?

[Myles C. Maxfield]

Comment on attachment 239433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239433&action=review

>> Source/WebCore/platform/graphics/SimpleFontData.h:163
>> +    void setAdjustedSpaceWidth(float adjustedSpaceWidth) { m_adjustedSpaceWidth = adjustedSpaceWidth; }
> 
> Maybe we should offer a setter that sets both?

Good idea. Done.

>> Source/WebCore/svg/SVGFontData.cpp:111
>> +    fontData->setSpaceWidth(spaceWidth);
> 
> Should't setAdjustedSpaceWidth(0) be called in the if (!glyphPageZero) above, especially if it's initialized with undefined?

Yep.

[Myles C. Maxfield]

Created attachment 239482 [details]
Patch

[Antti Koivisto]

Comment on attachment 239482 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239482&action=review

> Source/WebCore/platform/graphics/SimpleFontData.h:163
>      void setSpaceWidth(float spaceWidth) { m_spaceWidth = spaceWidth; }
> +    void setAllSpaceWidths(float spaceWidth)

setSpaceWidth won't have clients anymore. I think you can just have one setter called setSpaceWidths() that sets both.

[Myles C. Maxfield]

http://trac.webkit.org/changeset/174466