Bug 137448 - [jhbuild] Make it possible to build GTK/EFL in same repository
Summary: [jhbuild] Make it possible to build GTK/EFL in same repository
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-06 06:36 PDT by Tibor Mészáros
Modified: 2014-12-11 08:50 PST (History)
11 users (show)

See Also:


Attachments
Patch (6.61 KB, patch)
2014-10-06 06:40 PDT, Tibor Mészáros
no flags Details | Formatted Diff | Diff
Patch v2 (6.72 KB, patch)
2014-11-04 05:34 PST, Tibor Mészáros
no flags Details | Formatted Diff | Diff
Patch v3 (6.73 KB, patch)
2014-11-04 06:43 PST, Tibor Mészáros
mrobinson: review+
mrobinson: commit-queue-
Details | Formatted Diff | Diff
Patch v4 (6.75 KB, patch)
2014-11-04 06:52 PST, Tibor Mészáros
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tibor Mészáros 2014-10-06 06:36:01 PDT
Idea: use Dependencies-[EFL|GTK] or Dependencies/[EFL|GTK] instead of simple Dependencies
Comment 1 Tibor Mészáros 2014-10-06 06:40:19 PDT
Created attachment 239334 [details]
Patch

This patch will make it possible to build GTK/EFL in same repository.
Comment 2 Csaba Osztrogonác 2014-11-03 01:51:12 PST
It is so annoying when jhbuild clobbers the WebKitBuild/Dependencies 
when I try to build EFL after GTK and vice-versa.

I like the idea to use different build directory for dependecies of EFL and GTK.
The proposed patch looks good to me (and I tested too, it seems all scripts work), but I'm not 100% sure if everybody wants this change as is.

Carlos, Gyuyoung, any comment or concern?
Comment 3 Martin Robinson 2014-11-03 09:56:40 PST
I definitely support anything that makes development less painful. I do sort of prefer DependenciesGTK and DependenciesEFL to avoid making too deeply nested directories.
Comment 4 Tibor Mészáros 2014-11-04 05:34:21 PST
Created attachment 240923 [details]
Patch v2

This patch has been changed, as Martin Robinson suggested.
Comment 5 Martin Robinson 2014-11-04 06:18:49 PST
Comment on attachment 240923 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=240923&action=review

> Tools/Scripts/webkitdirs.pm:1645
> +    } else {
> +        push(@jhbuildPath, "DependenciesUnknown");
> +    }

You should probably print an error and quit in this case.
Comment 6 Tibor Mészáros 2014-11-04 06:43:30 PST
Created attachment 240925 [details]
Patch v3

Updated patch.
Comment 7 Martin Robinson 2014-11-04 06:46:03 PST
Comment on attachment 240925 [details]
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=240925&action=review

> Tools/Scripts/webkitdirs.pm:1644
> +        die "No platform specified. Use --gtk or --efl.\n";

The error here would be "Cannot get JHBuild path for platform that isn't GTK+ or EFL." since presumably not specifying a platform means --mac or whatever.
Comment 8 Tibor Mészáros 2014-11-04 06:52:21 PST
Created attachment 240926 [details]
Patch v4

Text has been updated, as you proposed.
Comment 9 WebKit Commit Bot 2014-11-04 11:05:42 PST
Comment on attachment 240926 [details]
Patch v4

Clearing flags on attachment: 240926

Committed r175555: <http://trac.webkit.org/changeset/175555>
Comment 10 WebKit Commit Bot 2014-11-04 11:05:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Éva Balázsfalvi 2014-11-10 07:53:33 PST
Quick fix for the test-font path: https://trac.webkit.org/changeset/175808
Comment 12 Philippe Normand 2014-12-02 02:20:35 PST
And another, https://bugs.webkit.org/show_bug.cgi?id=139176
Next time you rename something please grep it everywhere.
Comment 13 Carlos Alberto Lopez Perez 2014-12-11 08:50:34 PST
(In reply to comment #12)
> And another, https://bugs.webkit.org/show_bug.cgi?id=139176
> Next time you rename something please grep it everywhere.

And another one: https://bugs.webkit.org/show_bug.cgi?id=139537 :\