Bug 137448 – [jhbuild] Make it possible to build GTK/EFL in same repository

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Tibor Mészáros]

Idea: use Dependencies-[EFL|GTK] or Dependencies/[EFL|GTK] instead of simple Dependencies

[Tibor Mészáros]

Created attachment 239334 [details]
Patch

This patch will make it possible to build GTK/EFL in same repository.

[Csaba Osztrogonác]

It is so annoying when jhbuild clobbers the WebKitBuild/Dependencies 
when I try to build EFL after GTK and vice-versa.

I like the idea to use different build directory for dependecies of EFL and GTK.
The proposed patch looks good to me (and I tested too, it seems all scripts work), but I'm not 100% sure if everybody wants this change as is.

Carlos, Gyuyoung, any comment or concern?

[Martin Robinson]

I definitely support anything that makes development less painful. I do sort of prefer DependenciesGTK and DependenciesEFL to avoid making too deeply nested directories.

[Tibor Mészáros]

Created attachment 240923 [details]
Patch v2

This patch has been changed, as Martin Robinson suggested.

[Martin Robinson]

Comment on attachment 240923 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=240923&action=review

> Tools/Scripts/webkitdirs.pm:1645
> +    } else {
> +        push(@jhbuildPath, "DependenciesUnknown");
> +    }

You should probably print an error and quit in this case.

[Tibor Mészáros]

Created attachment 240925 [details]
Patch v3

Updated patch.

[Martin Robinson]

Comment on attachment 240925 [details]
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=240925&action=review

> Tools/Scripts/webkitdirs.pm:1644
> +        die "No platform specified. Use --gtk or --efl.\n";

The error here would be "Cannot get JHBuild path for platform that isn't GTK+ or EFL." since presumably not specifying a platform means --mac or whatever.

[Tibor Mészáros]

Created attachment 240926 [details]
Patch v4

Text has been updated, as you proposed.

[WebKit Commit Bot]

Comment on attachment 240926 [details]
Patch v4

Clearing flags on attachment: 240926

Committed r175555: <http://trac.webkit.org/changeset/175555>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Éva Balázsfalvi]

Quick fix for the test-font path: https://trac.webkit.org/changeset/175808

[Philippe Normand]

And another, https://bugs.webkit.org/show_bug.cgi?id=139176
Next time you rename something please grep it everywhere.

[Carlos Alberto Lopez Perez]

(In reply to comment #12)
> And another, https://bugs.webkit.org/show_bug.cgi?id=139176
> Next time you rename something please grep it everywhere.

And another one: https://bugs.webkit.org/show_bug.cgi?id=139537 :\