RESOLVED WONTFIX 137447
AX: Avoid unnecessary copies in invalidStatus method 
https://bugs.webkit.org/show_bug.cgi?id=137447
Summary AX: Avoid unnecessary copies in invalidStatus method
Krzysztof Czech
Reported 2014-10-06 05:40:33 PDT
Seems invalidStatus() method could be slightly changed so that it could return reference s to local static objects.
Attachments
proposed patch (2.79 KB, patch)
2014-10-06 05:52 PDT, Krzysztof Czech 		cfleizach: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-06 05:40:55 PDT
<rdar://problem/18553813>
Krzysztof Czech
Comment 2 2014-10-06 05:52:52 PDT
Created attachment 239331 [details] proposed patch
chris fleizach
Comment 3 2014-10-06 07:13:35 PDT
Comment on attachment 239331 [details] proposed patch At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is
Krzysztof Czech
Comment 4 2014-10-06 07:47:28 PDT
(In reply to comment #3) > (From update of attachment 239331 [details]) > At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is Thanks for clarifying me this, I do not know either what the current thinking is.
chris fleizach
Comment 5 2014-10-06 08:40:36 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 239331 [details] [details]) > > At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is > Thanks for clarifying me this, I do not know either what the current thinking is. My guess is that unless this is a hot patch of code people would probably prefer to not make more statics. Thx
Krzysztof Czech
Comment 6 2014-10-07 00:40:07 PDT
Thanks Chris for putting some light on this. It seems we should carefully add new statics.
chris fleizach
Comment 7 2014-12-03 09:53:40 PST
Comment on attachment 239331 [details] proposed patch I think we should probably skip this. Do you agree?
Krzysztof Czech
Comment 8 2014-12-05 00:44:08 PST
(In reply to comment #7) > Comment on attachment 239331 [details] > proposed patch > > I think we should probably skip this. Do you agree? Thanks Chris, yes I agree we should skip this one.
Note You need to log in before you can comment on or make changes to this bug.