Seems invalidStatus() method could be slightly changed so that it could return reference s to local static objects.
<rdar://problem/18553813>
Created attachment 239331 [details] proposed patch
Comment on attachment 239331 [details] proposed patch At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is
(In reply to comment #3) > (From update of attachment 239331 [details]) > At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is Thanks for clarifying me this, I do not know either what the current thinking is.
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 239331 [details] [details]) > > At some point I know we changed this to not be statics because people thought the cost of statics were higher than the cost of doing a string copy. I don't know what the current thinking is > Thanks for clarifying me this, I do not know either what the current thinking is. My guess is that unless this is a hot patch of code people would probably prefer to not make more statics. Thx
Thanks Chris for putting some light on this. It seems we should carefully add new statics.
Comment on attachment 239331 [details] proposed patch I think we should probably skip this. Do you agree?
(In reply to comment #7) > Comment on attachment 239331 [details] > proposed patch > > I think we should probably skip this. Do you agree? Thanks Chris, yes I agree we should skip this one.