WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137438
Use is<>() / downcast<>() for TextTrack subclasses
https://bugs.webkit.org/show_bug.cgi?id=137438
Summary
Use is<>() / downcast<>() for TextTrack subclasses
Chris Dumez
Reported
2014-10-05 17:39:15 PDT
Use is<>() / downcast<>() for TextTrack subclasses
Attachments
Patch
(6.68 KB, patch)
2014-10-05 17:43 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2014-10-05 17:43:20 PDT
Created
attachment 239308
[details]
Patch
Ryosuke Niwa
Comment 2
2014-10-05 21:35:05 PDT
Comment on
attachment 239308
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=239308&action=review
> Source/WebCore/html/track/TextTrackList.cpp:54 > -int TextTrackList::getTrackIndex(TextTrack *textTrack) > +int TextTrackList::getTrackIndex(TextTrack* textTrack)
We don't have to do it in this patch but we should use reference for textTrack.
WebKit Commit Bot
Comment 3
2014-10-05 22:11:00 PDT
Comment on
attachment 239308
[details]
Patch Clearing flags on attachment: 239308 Committed
r174338
: <
http://trac.webkit.org/changeset/174338
>
WebKit Commit Bot
Comment 4
2014-10-05 22:11:08 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug