Bug 137438 - Use is<>() / downcast<>() for TextTrack subclasses
Summary: Use is<>() / downcast<>() for TextTrack subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-05 17:39 PDT by Chris Dumez
Modified: 2014-10-05 22:11 PDT (History)
13 users (show)

See Also:

Attachments
Patch (6.68 KB, patch)
2014-10-05 17:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-05 17:39:15 PDT 
Use is<>() / downcast<>() for TextTrack subclasses
Comment 1 Chris Dumez 2014-10-05 17:43:20 PDT 
Created attachment 239308 [details]
Patch
Comment 2 Ryosuke Niwa 2014-10-05 21:35:05 PDT 
Comment on attachment 239308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239308&action=review

> Source/WebCore/html/track/TextTrackList.cpp:54
> -int TextTrackList::getTrackIndex(TextTrack *textTrack)
> +int TextTrackList::getTrackIndex(TextTrack* textTrack)

We don't have to do it in this patch but we should use reference for textTrack.
Comment 3 WebKit Commit Bot 2014-10-05 22:11:00 PDT 
Comment on attachment 239308 [details]
Patch

Clearing flags on attachment: 239308

Committed r174338: <http://trac.webkit.org/changeset/174338>
Comment 4 WebKit Commit Bot 2014-10-05 22:11:08 PDT 
All reviewed patches have been landed.  Closing bug.