RESOLVED FIXED 137431
Use is<>() / downcast<>() for CachedResource subclasses 
https://bugs.webkit.org/show_bug.cgi?id=137431
Summary Use is<>() / downcast<>() for CachedResource subclasses
Chris Dumez
Reported 2014-10-04 22:48:02 PDT
Use is<>() / downcast<>() for CachedResource subclasses
Attachments
Patch (18.05 KB, patch)
2014-10-04 23:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.10 KB, patch)
2014-10-05 16:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-04 23:04:48 PDT
Created attachment 239293 [details] Patch
Benjamin Poulain
Comment 2 2014-10-05 16:06:09 PDT
Comment on attachment 239293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239293&action=review > Source/WebCore/loader/cache/CachedResourceLoader.cpp:708 > + CachedImage& image = downcast<CachedImage>(*resource); > + image.load(this, defaultCachedResourceOptions()); Darin would probably prefer this on one line. Personally I like the named temporary here. Your call. > Source/WebKit/mac/Misc/WebCache.mm:205 > if (!cachedResource || !cachedResource->isImage()) Why keep this?
Chris Dumez
Comment 3 2014-10-05 16:46:40 PDT
Comment on attachment 239293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239293&action=review >> Source/WebCore/loader/cache/CachedResourceLoader.cpp:708 >> + image.load(this, defaultCachedResourceOptions()); > > Darin would probably prefer this on one line. Personally I like the named temporary here. > > Your call. Will drop the variable. >> Source/WebKit/mac/Misc/WebCache.mm:205 >> if (!cachedResource || !cachedResource->isImage()) > > Why keep this? I missed it, will use is<>()
Chris Dumez
Comment 4 2014-10-05 16:47:22 PDT
Created attachment 239304 [details] Patch
WebKit Commit Bot
Comment 5 2014-10-05 17:31:10 PDT
Comment on attachment 239304 [details] Patch Clearing flags on attachment: 239304 Committed r174333: <http://trac.webkit.org/changeset/174333>
WebKit Commit Bot
Comment 6 2014-10-05 17:31:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.