WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137429
Use is<>() / downcast<>() for StyleSheet subclasses
https://bugs.webkit.org/show_bug.cgi?id=137429
Summary
Use is<>() / downcast<>() for StyleSheet subclasses
Chris Dumez
Reported
2014-10-04 21:51:38 PDT
Use is<>() / downcast<>() for StyleSheet subclasses
Attachments
Patch
(8.54 KB, patch)
2014-10-04 22:14 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(8.60 KB, patch)
2014-10-05 16:37 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2014-10-04 22:14:02 PDT
Created
attachment 239291
[details]
Patch
Benjamin Poulain
Comment 2
2014-10-05 15:54:40 PDT
Comment on
attachment 239291
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=239291&action=review
> Source/WebCore/dom/DocumentStyleSheetCollection.cpp:411 > for (unsigned i = 0; i < sheets.size(); ++i) {
Let's update the loop too.
> Source/WebCore/dom/DocumentStyleSheetCollection.cpp:413 > + if (!is<CSSStyleSheet>(*sheets[i])) > continue;
I would move this after sheets[i]->disabled() to reduce the span between is<> and downcast<>, making it easier to follow the flow.
Chris Dumez
Comment 3
2014-10-05 16:37:58 PDT
Created
attachment 239302
[details]
Patch
WebKit Commit Bot
Comment 4
2014-10-05 17:24:00 PDT
Comment on
attachment 239302
[details]
Patch Clearing flags on attachment: 239302 Committed
r174332
: <
http://trac.webkit.org/changeset/174332
>
WebKit Commit Bot
Comment 5
2014-10-05 17:24:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug