Bug 137422 – [GTK] Move GtkDragAndDropHelper from Platform to WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

WebKitWebViewBase is currently the only user of GtkDragAndDropHelper, that was added to share the code with WebKit1. This removes another file in platform that is built twice for the plugin process.

[Carlos Garcia Campos]

Created attachment 239278 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 239278 [details]
Patch

I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory?

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 239278 [details])
> I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory?

Well, I don't think the current class is cleaner, it was only needed to share the code with WebKit1, but I never liked some things like setWidget() or the DragExited callback. In some cases the handleFoo methods are just one line of code, so I don't think another unneeded layer makes things cleaner.

[Carlos Garcia Campos]

Created attachment 240018 [details]
Updated patch to move all the dnd logic to a class

[Carlos Garcia Campos]

Committed r174868: <http://trac.webkit.org/changeset/174868>