Bug 137422 - [GTK] Move GtkDragAndDropHelper from Platform to WebKit2
Summary: [GTK] Move GtkDragAndDropHelper from Platform to WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-10-04 04:40 PDT by Carlos Garcia Campos
Modified: 2014-10-19 00:33 PDT (History)
8 users (show)

See Also:

Attachments
Patch (24.14 KB, patch)
2014-10-04 04:42 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch to move all the dnd logic to a class (45.04 KB, patch)
2014-10-17 10:07 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-10-04 04:40:38 PDT 
WebKitWebViewBase is currently the only user of GtkDragAndDropHelper, that was added to share the code with WebKit1. This removes another file in platform that is built twice for the plugin process.
Comment 1 Carlos Garcia Campos 2014-10-04 04:42:30 PDT 
Created attachment 239278 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-04 04:44:19 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2014-10-04 13:53:40 PDT 
Comment on attachment 239278 [details]
Patch

I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory?
Comment 4 Carlos Garcia Campos 2014-10-05 00:34:42 PDT 
(In reply to comment #3)
> (From update of attachment 239278 [details])
> I think it's cleaner to keep the drag and drop support separate from the rest of the widget. What if we just move this file to the WebKit2 directory?

Well, I don't think the current class is cleaner, it was only needed to share the code with WebKit1, but I never liked some things like setWidget() or the DragExited callback. In some cases the handleFoo methods are just one line of code, so I don't think another unneeded layer makes things cleaner.
Comment 5 Carlos Garcia Campos 2014-10-17 10:07:01 PDT 
Created attachment 240018 [details]
Updated patch to move all the dnd logic to a class
Comment 6 Carlos Garcia Campos 2014-10-19 00:33:24 PDT 
Committed r174868: <http://trac.webkit.org/changeset/174868>