Bug 137410 - Bugzilla status bubble displays an exception showing attachment 175738 [details]
Summary: Bugzilla status bubble displays an exception showing attachment 175738
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL: http://webkit-queues.appspot.com/stat...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-03 15:51 PDT by Alexey Proskuryakov
Modified: 2014-10-03 16:49 PDT (History)
1 user (show)

See Also:


Attachments
proposed fix (3.67 KB, patch)
2014-10-03 15:54 PDT, Alexey Proskuryakov
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-10-03 15:51:48 PDT
This old attachment has an incorrect status queue log. We should be tolerant of that.
Comment 1 Alexey Proskuryakov 2014-10-03 15:54:20 PDT
Created attachment 239247 [details]
proposed fix
Comment 2 Tim Horton 2014-10-03 16:33:22 PDT
Comment on attachment 239247 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review

> Tools/QueueStatusServer/app.yaml:2
> +version: ap # Bugzilla bug ID of last major change

please fix the comment.

> Tools/QueueStatusServer/handlers/statusbubble.py:141
> +                message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message

IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer
Comment 3 Alexey Proskuryakov 2014-10-03 16:37:08 PDT
Committed <http://trac.webkit.org/r174303>.
Comment 4 Tim Horton 2014-10-03 16:37:43 PDT
Comment on attachment 239247 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=239247&action=review

>> Tools/QueueStatusServer/handlers/statusbubble.py:141
>> +                message_to_display = statuses[1].message if len(statuses) > 1 else statuses[0].message
> 
> IIRC 'if statuses' is sufficient (an empty list evaluates to false) but this is probably clearer

Nevermind!
Comment 5 Alexey Proskuryakov 2014-10-03 16:49:20 PDT
Actually committed in 174304