Bug 137386 – REGRESSION (r173265): UIWebView PDF loading is completely broken

• Status: RESOLVED
• Resolution: FIXED
• Component: PDF

[Tim Horton]

The WebPDFViewPlaceholder changes in r173265 completely broke loading by ... removing the code that completes the load.

Let's put it back.

rdar://problem/18524717

[Tim Horton]

Created attachment 239192 [details]
patch

[Tim Horton]

Comment on attachment 239192 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239192&action=review

> Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm:287
> +    // Dump the data provider as soon as possible since the CGPDFDocument will not hold onto it.

I'm not sure this comment makes sense to me (I'm just restoring it, but maybe we should refrain).

[Tim Horton]

Comment on attachment 239192 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239192&action=review

> Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm:285
> +    _document = CGPDFDocumentCreateWithProvider(provider);

No idea why this is manually memory-managed like this, but we should fix that in a different patch.

[David Kilzer (:ddkilzer)]

Comment on attachment 239192 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239192&action=review

r=me

>> Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm:287
>> +    // Dump the data provider as soon as possible since the CGPDFDocument will not hold onto it.
> 
> I'm not sure this comment makes sense to me (I'm just restoring it, but maybe we should refrain).

Yes, let's remove the comment.  It doesn't appear to add anything useful.

[Tim Horton]

http://trac.webkit.org/changeset/174282