RESOLVED FIXED 137383
WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset 
https://bugs.webkit.org/show_bug.cgi?id=137383
Summary WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset
Tim Horton
Reported 2014-10-03 00:18:17 PDT
WKWebView snapshot of Daring Fireball has the wrong color in the obscured inset
Attachments
Patch (4.39 KB, patch)
2014-10-03 00:19 PDT, Tim Horton 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-10-03 00:19:07 PDT
Created attachment 239183 [details] Patch
Tim Horton
Comment 2 2014-10-03 00:19:42 PDT
rdar://problem/18535439
Daniel Bates
Comment 3 2014-10-03 10:17:24 PDT
Comment on attachment 239183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239183&action=review > Source/WebCore/ChangeLog:11 > + Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set. I take it you meant to write documentBackgroundColor instead of pageExtendedBackgroundColor. > Source/WebKit2/ChangeLog:11 > + Use pageExtendedBackgroundColor instead of baseBackgroundColor if backgroundShouldExtendBeyondPage is set. Ditto. > Source/WebCore/rendering/RenderView.cpp:590 > + Color backgroundColor = backgroundShouldExtendBeyondPage ? frameView().documentBackgroundColor() : frameView().baseBackgroundColor(); Should we add a remark about this in the comment block that starts at line 583: <http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderView.cpp?rev=173865#L583>?
Tim Horton
Comment 4 2014-10-03 13:37:11 PDT
http://trac.webkit.org/changeset/174287
Note You need to log in before you can comment on or make changes to this bug.