Bug 137377 – -asan-blacklist option also renamed to generic -fsanitize-blacklist

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Farler]

In addition to the ASan flags moving up to the clang front-end, the generic -fsanitize-blacklist is now used for the ASan symbol blacklist as well.

[David Farler]

Created attachment 239172 [details]
Patch

[Daniel Bates]

Comment on attachment 239172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review

> Tools/ChangeLog:9
> +        * asan/asan.xcconfig:
> +        -asan-blacklist -> -fsanitize-blacklist

Do we know version/revision of clang added support for -fsanitize-blacklist? If so, or if it's straightforward to determine this, then I suggest we add a remark to this change log entry about the version/revision of clang that added such support.

[Daniel Bates]

(In reply to comment #2)
> (From update of attachment 239172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review
> 
> > Tools/ChangeLog:9
> > +        * asan/asan.xcconfig:
> > +        -asan-blacklist -> -fsanitize-blacklist
> 
> Do we know version/revision of clang added support for -fsanitize-blacklist? [...]

I meant to write:

Do we know which version/revision of clang added support for -fsanitize-blacklist?

[David Farler]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 239172 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review
> > 
> > > Tools/ChangeLog:9
> > > +        * asan/asan.xcconfig:
> > > +        -asan-blacklist -> -fsanitize-blacklist
> > 
> > Do we know version/revision of clang added support for -fsanitize-blacklist? [...]
> 
> I meant to write:
> 
> Do we know which version/revision of clang added support for -fsanitize-blacklist?

-fsanitize-blacklist is a generic option that has been available for quite some time, way before ASan was available. I’ll reference the same revision in my previous patch.

[David Farler]

Committed r174290: <http://trac.webkit.org/changeset/174290>