Bug 137377 - -asan-blacklist option also renamed to generic -fsanitize-blacklist
Summary: -asan-blacklist option also renamed to generic -fsanitize-blacklist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Farler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-02 18:41 PDT by David Farler
Modified: 2014-10-03 14:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2014-10-02 18:49 PDT, David Farler 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2014-10-02 18:41:11 PDT 
In addition to the ASan flags moving up to the clang front-end, the generic -fsanitize-blacklist is now used for the ASan symbol blacklist as well.
Comment 1 David Farler 2014-10-02 18:49:39 PDT 
Created attachment 239172 [details]
Patch
Comment 2 Daniel Bates 2014-10-03 10:32:54 PDT 
Comment on attachment 239172 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review

> Tools/ChangeLog:9
> +        * asan/asan.xcconfig:
> +        -asan-blacklist -> -fsanitize-blacklist

Do we know version/revision of clang added support for -fsanitize-blacklist? If so, or if it's straightforward to determine this, then I suggest we add a remark to this change log entry about the version/revision of clang that added such support.
Comment 3 Daniel Bates 2014-10-03 10:33:51 PDT 
(In reply to comment #2)
> (From update of attachment 239172 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review
> 
> > Tools/ChangeLog:9
> > +        * asan/asan.xcconfig:
> > +        -asan-blacklist -> -fsanitize-blacklist
> 
> Do we know version/revision of clang added support for -fsanitize-blacklist? [...]

I meant to write:

Do we know which version/revision of clang added support for -fsanitize-blacklist?
Comment 4 David Farler 2014-10-03 14:16:20 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 239172 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=239172&action=review
> > 
> > > Tools/ChangeLog:9
> > > +        * asan/asan.xcconfig:
> > > +        -asan-blacklist -> -fsanitize-blacklist
> > 
> > Do we know version/revision of clang added support for -fsanitize-blacklist? [...]
> 
> I meant to write:
> 
> Do we know which version/revision of clang added support for -fsanitize-blacklist?

-fsanitize-blacklist is a generic option that has been available for quite some time, way before ASan was available. I’ll reference the same revision in my previous patch.
Comment 5 David Farler 2014-10-03 14:18:42 PDT 
Committed r174290: <http://trac.webkit.org/changeset/174290>