Bug 137358 – [iOS] Teach WKPDFView to navigate to pageNumber links

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Teach WKPDFView to navigate to pageNumber links

[Andy Estes]

rdar://problem/18334903

[Andy Estes]

Created attachment 239137 [details]
Patch

[WebKit Commit Bot]

Attachment 239137 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKPDFView.mm:356:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 239137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239137&action=review

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:359
> +        urlString = String::format("#page%lu", pageNumber);

I'm not sure String::format is the best way to do this. I realize that this isn't performance critical code, but still probably not a great example to set.

[Andy Estes]

(In reply to comment #4)
> (From update of attachment 239137 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239137&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKPDFView.mm:359
> > +        urlString = String::format("#page%lu", pageNumber);
> 
> I'm not sure String::format is the best way to do this. I realize that this isn't performance critical code, but still probably not a great example to set.

What's the alternative? append '0' + pageNumber as a character literal?

[Andy Estes]

Oh never mind, WTFString has a bunch of number conversion functions.

[Andy Estes]

Committed r174232: <http://trac.webkit.org/changeset/174232>

[Darin Adler]

Comment on attachment 239137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239137&action=review

>>> Source/WebKit2/UIProcess/ios/WKPDFView.mm:359
>>> +        urlString = String::format("#page%lu", pageNumber);
>> 
>> I'm not sure String::format is the best way to do this. I realize that this isn't performance critical code, but still probably not a great example to set.
> 
> What's the alternative? append '0' + pageNumber as a character literal?

One alternative is to use StringBuilder and appendNumber. I don’t think it’s higher performance than String::format, but it does avoid the assumption that NSUInteger is always unsigned long, which this code makes by using %lu for it.