RESOLVED FIXED 137355
Clean up interface to Font::expansionOpportunityCount() 
https://bugs.webkit.org/show_bug.cgi?id=137355
Summary Clean up interface to Font::expansionOpportunityCount()
Myles C. Maxfield
Reported 2014-10-02 13:13:10 PDT
Clean up interface to Font::expansionOpportunityCount()
Attachments
Patch (11.08 KB, patch)
2014-10-02 13:17 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (10.20 KB, patch)
2014-10-03 14:04 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-10-02 13:17:06 PDT
Created attachment 239132 [details] Patch
Myles C. Maxfield
Comment 2 2014-10-03 12:19:28 PDT
This needs to be rebaselined.
Myles C. Maxfield
Comment 3 2014-10-03 12:19:46 PDT
**** The code needs to be rebased
Myles C. Maxfield
Comment 4 2014-10-03 14:04:09 PDT
Created attachment 239231 [details] Patch
WebKit Commit Bot
Comment 5 2014-10-03 15:07:47 PDT
Comment on attachment 239231 [details] Patch Clearing flags on attachment: 239231 Committed r174297: <http://trac.webkit.org/changeset/174297>
WebKit Commit Bot
Comment 6 2014-10-03 15:07:51 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2014-10-03 22:02:33 PDT
Comment on attachment 239231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239231&action=review > Source/WebCore/rendering/RenderText.cpp:1533 > +StringView RenderText::stringView(int start, int stop) const > +{ > + if (is8Bit()) > + return StringView(characters8() + start, stop - start); > + return StringView(characters16() + start, stop - start); > +} This function either needs assertions about start and stop being reasonable values, or code to clamp start and stop to make them reasonable values.
Myles C. Maxfield
Comment 8 2014-10-06 16:54:47 PDT
Comment on attachment 239231 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239231&action=review >> Source/WebCore/rendering/RenderText.cpp:1533 >> +} > > This function either needs assertions about start and stop being reasonable values, or code to clamp start and stop to make them reasonable values. Addressed in r174373.
Note You need to log in before you can comment on or make changes to this bug.