TextRun::length() should return an unsigned
Created attachment 239131 [details] Patch
Created attachment 239149 [details] Patch
Created attachment 239150 [details] Patch
Comment on attachment 239150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239150&action=review > Source/WebCore/platform/graphics/GlyphBuffer.h:127 > + static const unsigned kNoOffset = UINT_MAX; You could drop the initial 'k'. That doesn't match our current style. Using std::numeric_limits<unsigned>::max() would be more stylish than UINT_MAX.
Comment on attachment 239150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239150&action=review >> Source/WebCore/platform/graphics/GlyphBuffer.h:127 >> + static const unsigned kNoOffset = UINT_MAX; > > You could drop the initial 'k'. That doesn't match our current style. > Using std::numeric_limits<unsigned>::max() would be more stylish than UINT_MAX. The Microsoft compiler doesn't support constexpr, which means that it errors when it sees something that looks like a function here :( Originally it was std::numeric_limits<unsigned>::max() but I had to change it when the windows EFL bot went red.
Comment on attachment 239150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239150&action=review >>> Source/WebCore/platform/graphics/GlyphBuffer.h:127 >>> + static const unsigned kNoOffset = UINT_MAX; >> >> You could drop the initial 'k'. That doesn't match our current style. >> Using std::numeric_limits<unsigned>::max() would be more stylish than UINT_MAX. > > The Microsoft compiler doesn't support constexpr, which means that it errors when it sees something that looks like a function here :( Originally it was std::numeric_limits<unsigned>::max() but I had to change it when the windows EFL bot went red. ***Windows EWS bot
http://trac.webkit.org/changeset/174269
Windows build fix checked in under <http://trac.webkit.org/changeset/174272>.