WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137354
TextRun::length() should return an unsigned
https://bugs.webkit.org/show_bug.cgi?id=137354
Summary
TextRun::length() should return an unsigned
Myles C. Maxfield
Reported
2014-10-02 12:53:28 PDT
TextRun::length() should return an unsigned
Attachments
Patch
(10.80 KB, patch)
2014-10-02 13:03 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch
(11.56 KB, patch)
2014-10-02 15:57 PDT
,
Myles C. Maxfield
no flags
Details
Formatted Diff
Diff
Patch
(11.77 KB, patch)
2014-10-02 16:12 PDT
,
Myles C. Maxfield
koivisto
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1
2014-10-02 13:03:26 PDT
Created
attachment 239131
[details]
Patch
Myles C. Maxfield
Comment 2
2014-10-02 15:57:45 PDT
Created
attachment 239149
[details]
Patch
Myles C. Maxfield
Comment 3
2014-10-02 16:12:22 PDT
Created
attachment 239150
[details]
Patch
Antti Koivisto
Comment 4
2014-10-03 01:53:37 PDT
Comment on
attachment 239150
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=239150&action=review
> Source/WebCore/platform/graphics/GlyphBuffer.h:127 > + static const unsigned kNoOffset = UINT_MAX;
You could drop the initial 'k'. That doesn't match our current style. Using std::numeric_limits<unsigned>::max() would be more stylish than UINT_MAX.
Myles C. Maxfield
Comment 5
2014-10-03 09:22:31 PDT
Comment on
attachment 239150
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=239150&action=review
>> Source/WebCore/platform/graphics/GlyphBuffer.h:127 >> + static const unsigned kNoOffset = UINT_MAX; > > You could drop the initial 'k'. That doesn't match our current style. > Using std::numeric_limits<unsigned>::max() would be more stylish than UINT_MAX.
The Microsoft compiler doesn't support constexpr, which means that it errors when it sees something that looks like a function here :( Originally it was std::numeric_limits<unsigned>::max() but I had to change it when the windows EFL bot went red.
Myles C. Maxfield
Comment 6
2014-10-03 09:30:36 PDT
Comment on
attachment 239150
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=239150&action=review
>>> Source/WebCore/platform/graphics/GlyphBuffer.h:127 >>> + static const unsigned kNoOffset = UINT_MAX; >> >> You could drop the initial 'k'. That doesn't match our current style. >> Using std::numeric_limits<unsigned>::max() would be more stylish than UINT_MAX. > > The Microsoft compiler doesn't support constexpr, which means that it errors when it sees something that looks like a function here :( Originally it was std::numeric_limits<unsigned>::max() but I had to change it when the windows EFL bot went red.
***Windows EWS bot
Myles C. Maxfield
Comment 7
2014-10-03 09:57:44 PDT
http://trac.webkit.org/changeset/174269
Brent Fulgham
Comment 8
2014-10-03 10:56:55 PDT
Windows build fix checked in under <
http://trac.webkit.org/changeset/174272
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug