Bug 137351 – Change layout-test-results directory to test-results directory

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Jake Nielsen]

Tests results should be bundled together in one directory, and hence layout-test-results will soon become a misnomer, but due to the potential fragility of this name change I want to submit it as a patch of its own.

[Jake Nielsen]

Created attachment 239125 [details]
Performs the dreaded name change

[Daniel Bates]

Comment on attachment 239125 [details]
Performs the dreaded name change

OK.

[Daniel Bates]

Comment on attachment 239125 [details]
Performs the dreaded name change

cq-'ing this may break the builders if we don't coordinate updating the master buildbot config.

[Daniel Bates]

Comment on attachment 239125 [details]
Performs the dreaded name change

View in context: https://bugs.webkit.org/attachment.cgi?id=239125&action=review

> Tools/BuildSlaveSupport/test-result-archive:32
> -archiveFile = os.path.join(sourceRootDirectory, "layout-test-results.zip")
> +archiveFile = os.path.join(sourceRootDirectory, "test-results.zip")
>  
>  def main():
>      parser = optparse.OptionParser("usage: %prog [options] [action]")

Further elaborating on my remark in comment #3 (above), this change will lead to the "archive-test-results" step to fail on the bots if the buildbot master config change (included in this patch) is not applied after landing this patch (*).

(*) I'm unclear of the process for updating the build.webkit.org buildbot master config. I suspect we must manually update the master config as opposed to it automatically taking effect upon commit. If we are unable to guarantee that the the master config change will take effect after landing this patch then we should have logic to temporarily handle both the old and new name for the archive file. After we update the buildbot master config then we can remove support for handling the old archive name.

> Tools/BuildSlaveSupport/test-result-archive:45
> +    layoutTestResultsDir = os.path.abspath(os.path.join(sourceRootDirectory, "test-results"))

Ditto.

[Jake Nielsen]

Because there are so many things that depend on layout-test-results remaining where it is, Lucas suggested a much more sane approach to simply add sister directories for each of the other test results. As such, I'm just going to abandon this patch and have at it from that direction.