Bug 137344 - Suppress warnings on GCC: google-tests header mis-recognize false as null literal
Summary: Suppress warnings on GCC: google-tests header mis-recognize false as null lit...
Status: RESOLVED DUPLICATE of bug 137360
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-02 08:44 PDT by Yusuke Suzuki
Modified: 2014-10-03 19:13 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.89 KB, patch)
2014-10-02 08:48 PDT, Yusuke Suzuki 		cdumez: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2014-10-02 08:44:54 PDT 
Suppress warnings on GCC: google-tests header mis-recognize false as null literal
Comment 1 Yusuke Suzuki 2014-10-02 08:48:53 PDT 
Created attachment 239111 [details]
Patch
Comment 2 Chris Dumez 2014-10-03 16:27:13 PDT 
Comment on attachment 239111 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-10-03 18:57:13 PDT 
Comment on attachment 239111 [details]
Patch

Rejecting attachment 239111 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 239111, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
de: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp
Hunk #1 FAILED at 166.
Hunk #2 FAILED at 218.
2 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Christophe Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5926707538165760
Comment 4 Yusuke Suzuki 2014-10-03 19:13:36 PDT 
Ah, the other patch contains this patch's change.
https://bugs.webkit.org/show_bug.cgi?id=137360

Thank you for your review, Chris :)

*** This bug has been marked as a duplicate of bug 137360 ***