Bug 137343 - Remove autoinstaller workaround for python 2.6
Summary: Remove autoinstaller workaround for python 2.6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-02 06:27 PDT by Éva Balázsfalvi
Modified: 2014-10-03 03:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.32 KB, patch)
2014-10-02 06:32 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Patch for landing (10.52 KB, patch)
2014-10-03 02:32 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-10-02 06:27:47 PDT 
Rollout patch for http://trac.webkit.org/changeset/124928

Neither Python 2.6, nor Snow Leopard is supported anymore, so this workaround is not needed anymore.
Comment 1 Éva Balázsfalvi 2014-10-02 06:32:49 PDT 
Created attachment 239106 [details]
Patch
Comment 2 Daniel Bates 2014-10-02 09:44:59 PDT 
Comment on attachment 239106 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239106&action=review

> Tools/ChangeLog:7
> +

Although mentioned in the bug description for this bug (comment #0), I suggest that we add a remark that this patch reverts <http://trac.webkit.org/changeset/124928> in the ChangeLog entry for convenience.
Comment 3 Daniel Bates 2014-10-02 09:47:08 PDT 
(In reply to comment #2)
> (From update of attachment 239106 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239106&action=review
> 
> > Tools/ChangeLog:7
> > +
> 
> Although mentioned in the bug description for this bug (comment #0), I suggest that we add a remark that this patch reverts <http://trac.webkit.org/changeset/124928> in the ChangeLog entry for convenience.

We should also reiterate in the ChangeLog entry that the workaround isn't applicable anymore because we don't no longer support Snow Leopard.
Comment 4 Éva Balázsfalvi 2014-10-03 02:32:34 PDT 
Created attachment 239197 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-10-03 03:13:43 PDT 
Comment on attachment 239197 [details]
Patch for landing

Clearing flags on attachment: 239197

Committed r174263: <http://trac.webkit.org/changeset/174263>
Comment 6 WebKit Commit Bot 2014-10-03 03:13:47 PDT 
All reviewed patches have been landed.  Closing bug.