Bug 137327 – [Subpixel] Use floats instead of ints for text justification expansion, and associated cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Subpixel] Use floats instead of ints for text justification expansion, and associated cleanup

[Myles C. Maxfield]

Created attachment 239072 [details]
Patch

[Myles C. Maxfield]

Created attachment 239074 [details]
Patch

[Myles C. Maxfield]

Created attachment 239122 [details]
Patch

[alan]

Comment on attachment 239122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review

Looks good to me. Andreas, do you think expanding the InlineBox size is still an issue now that we've got simple line layout?

> Source/WebCore/ChangeLog:3
> +        [Subpixel] Use floats instead of ints for text justification expansion, and associated cleanup

minus the "associated cleanup"

[Andreas Kling]

(In reply to comment #4)
> (From update of attachment 239122 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review
> 
> Looks good to me. Andreas, do you think expanding the InlineBox size is still an issue now that we've got simple line layout?

I think it's okay to grow InlineBox a bit. Yay for simple line layout!

[alan]

Comment on attachment 239122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review

> Source/WebCore/rendering/InlineBox.h:283
> +    float m_expansion;

Private?

[Build Bot]

Comment on attachment 239122 [details]
Patch

Attachment 239122 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5558973243588608

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 239128 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 239122 [details]
Patch

Attachment 239122 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6574436924784640

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 239130 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Myles C. Maxfield]

Comment on attachment 239122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239122&action=review

>> Source/WebCore/ChangeLog:3
>> +        [Subpixel] Use floats instead of ints for text justification expansion, and associated cleanup
> 
> minus the "associated cleanup"

Done.

>> Source/WebCore/rendering/InlineBox.h:283
>> +    float m_expansion;
> 
> Private?

Done.

[Myles C. Maxfield]

http://trac.webkit.org/changeset/174233

[Pavel Marakhovski]

*** Bug 137016 has been marked as a duplicate of this bug. ***

[David Kilzer (:ddkilzer)]

<rdar://problem/18549311>