Bug 137270 - Use is<>() / downcast<>() for ContainerNode
Summary: Use is<>() / downcast<>() for ContainerNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-30 14:31 PDT by Chris Dumez
Modified: 2014-09-30 16:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (22.64 KB, patch)
2014-09-30 14:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-30 14:31:19 PDT 
Use is<>() / downcast<>() for ContainerNode instead of isContainerNode() / toContainerNode().
Comment 1 Chris Dumez 2014-09-30 14:38:50 PDT 
Created attachment 238964 [details]
Patch
Comment 2 Andreas Kling 2014-09-30 15:25:38 PDT 
Comment on attachment 238964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238964&action=review

r=me

> Source/WebCore/dom/Node.h:-745
> -// FIXME: This should be removed and all uses should be replaced with SPECIALIZE_TYPE_TRAITS_*().
> -#define NODE_TYPE_CASTS(ToClassName) \
> -    TYPE_CASTS_BASE(ToClassName, Node, node, WebCore::is##ToClassName(*node), WebCore::is##ToClassName(node))

Yay!
Comment 3 WebKit Commit Bot 2014-09-30 16:03:43 PDT 
Comment on attachment 238964 [details]
Patch

Clearing flags on attachment: 238964

Committed r174132: <http://trac.webkit.org/changeset/174132>
Comment 4 WebKit Commit Bot 2014-09-30 16:03:49 PDT 
All reviewed patches have been landed.  Closing bug.