RESOLVED FIXED 137257
Web Inspector: ErrorString should be passed by reference 
https://bugs.webkit.org/show_bug.cgi?id=137257
Summary Web Inspector: ErrorString should be passed by reference
Brian Burg
Reported 2014-09-30 11:26:22 PDT
.
Attachments
Patch (278.10 KB, patch)
2014-09-30 11:42 PDT, Brian Burg 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-09-30 11:26:30 PDT
<rdar://problem/18503485>
Brian Burg
Comment 2 2014-09-30 11:42:20 PDT
Created attachment 238942 [details] Patch
WebKit Commit Bot
Comment 3 2014-09-30 11:44:34 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4 2014-09-30 11:44:50 PDT
Attachment 238942 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorReplayAgent.h:107: The parameter name "segmentState" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:114: The parameter name "pseudoIdMatches" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 72 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 5 2014-09-30 11:47:52 PDT
Comment on attachment 238942 [details] Patch r=me, nice little cleanups too (ASCIILiteral).
Brian Burg
Comment 6 2014-11-12 13:24:33 PST
This was landed manually in <http://trac.webkit.org/changeset/174140>.
Note You need to log in before you can comment on or make changes to this bug.