Bug 137251 - Remove thirdparty/unittest2 from webkitpy
Summary: Remove thirdparty/unittest2 from webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-30 06:34 PDT by Éva Balázsfalvi
Modified: 2014-09-30 17:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (119.28 KB, patch)
2014-09-30 09:24 PDT, Éva Balázsfalvi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Éva Balázsfalvi 2014-09-30 06:34:37 PDT 
Remove thirdparty/unittest2 from webkitpy
Comment 1 Éva Balázsfalvi 2014-09-30 09:24:13 PDT 
Created attachment 238930 [details]
Patch
Comment 2 Ryosuke Niwa 2014-09-30 09:38:41 PDT 
What is the point of this patch?  Why are we removing it?  I thought we purposely started using unittest2 for some feature it provided.
Comment 3 Brent Fulgham 2014-09-30 16:27:11 PDT 
Comment on attachment 238930 [details]
Patch

r=me. I had planned on proposing this patch today as well! Thanks for beating me to it! :-)
Comment 4 Brent Fulgham 2014-09-30 16:28:10 PDT 
(In reply to comment #2)
> What is the point of this patch?  Why are we removing it?  I thought we purposely started using unittest2 for some feature it provided.

The "unites" that ships with Python 2.7 is the same as the "unittest2" stuff in our repository. So we are just getting rid of our custom local (probably outdated) version of this library in favor of the official version that now ships with Python.
Comment 5 Brent Fulgham 2014-09-30 16:32:45 PDT 
From the documentation on "unittest2":

"unittest2 is a backport of the new features added to the unittest testing framework in Python 2.7. It is tested to run on Python 2.4 - 2.7."
Comment 6 WebKit Commit Bot 2014-09-30 17:11:45 PDT 
Comment on attachment 238930 [details]
Patch

Clearing flags on attachment: 238930

Committed r174136: <http://trac.webkit.org/changeset/174136>
Comment 7 WebKit Commit Bot 2014-09-30 17:11:49 PDT 
All reviewed patches have been landed.  Closing bug.