TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspector... (pid=17886) /webkit2/WebKitWebInspector/default: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:182:void testInspectorDefault(InspectorTest*, gconstpointer): assertion failed: (webkit_web_inspector_is_attached(test->m_inspector)) FAIL GTester: last random seed: R02Sb5a3208cbed2ede13a44add0e3064a3b (pid=17934) /webkit2/WebKitWebInspector/manual-attach-detach: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:302:void testInspectorManualAttachDetach(CustomInspectorTest*, gconstpointer): assertion failed: (webkit_web_inspector_is_attached(test->m_inspector)) FAIL GTester: last random seed: R02S8b3ab0382d9c8b6c83596d3a75ce7e81 (pid=17980) /webkit2/WebKitWebInspector/custom-container-destroyed: OK FAIL: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspector The problem is that the test does this: resizeView(); // To make room for the attached inspector. attach(); but since r173929 the attach availability is no longer synchronous, and attach right after resizeView() does nothing.
Created attachment 238914 [details] Patch
Comment on attachment 238914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238914&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp:157 > + _("Can Atach"), Attach
Created attachment 238915 [details] Fix typo
Comment on attachment 238915 [details] Fix typo Looks good to me!
Committed r174105: <http://trac.webkit.org/changeset/174105>