WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137245
It should be fun and easy to run every possible JavaScript benchmark from the command line
https://bugs.webkit.org/show_bug.cgi?id=137245
Summary
It should be fun and easy to run every possible JavaScript benchmark from the...
Filip Pizlo
Reported
2014-09-29 21:11:08 PDT
We previously had Tools/Scripts/bencher. Then we stopped adding things to it because we weren't sure about the licensing of things like Kraken and Octane. Various people ended up having their own private scripts for doing benchmark runs, and didn't share them in the open source community, because of fears about the shady licensing of the benchmarks suites that they were running. We should fix this by having a script that just takes a configuration file with paths to the various benchmark scripts that cannot be safely checked into the WebKit repository. It's up to the person running the benchmarks to download the benchmark suites from wherever they can find them.
Attachments
the patch
(188.30 KB, patch)
2014-09-29 21:32 PDT
,
Filip Pizlo
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2014-09-29 21:32:16 PDT
Created
attachment 238908
[details]
the patch
Saam Barati
Comment 2
2014-09-30 00:05:10 PDT
Comment on
attachment 238908
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=238908&action=review
In initial testing, it seems to work exactly as expected. I'll be using it more extensively as I test the performance of my upcoming DFG patch and I'll let you know if I run into any problems. Thanks :)
> Tools/Scripts/run-jsc-benchmarks:275 > + puts "of the form Conf#<n> will be ascribed to the configuration automatically."
Maybe it's worth also adding in that each vm can be given a set of specific CLI options just for that vm, because I didn't know this until you mentioned it to me. Maybe something like: ... or of the string of the form <name>:<options>:<path> or <name>:<path> where <path> is the path to the executable, <options> are the command line options you want passed into this specific vm (i.e, JSC_useJIT=0), and <name> is the name that you would like to give the configuration for the purpose of reporting.
Filip Pizlo
Comment 3
2014-09-30 14:10:53 PDT
(In reply to
comment #2
)
> (From update of
attachment 238908
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=238908&action=review
> > In initial testing, it seems to work exactly as expected. I'll be using it more extensively as I test the performance of my upcoming DFG patch and I'll let you know if I run into any problems. > > Thanks :) > > > Tools/Scripts/run-jsc-benchmarks:275 > > + puts "of the form Conf#<n> will be ascribed to the configuration automatically." > > Maybe it's worth also adding in that each vm can be given a set of specific CLI options just for that vm, because I didn't know this until you mentioned it to me. > > Maybe something like: > ... > or of the string of the form <name>:<options>:<path> or <name>:<path> > where <path> is the path to the executable, <options> are the command line options you want passed into this specific vm (i.e, JSC_useJIT=0), and <name> is the name that you would like to give the configuration for the purpose of reporting.
Yup, I added some text about this!
Filip Pizlo
Comment 4
2014-09-30 14:12:59 PDT
Landed in
http://trac.webkit.org/changeset/174123
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug