Bug 137240 - build.webkit.org/dashboard: Switch EWS view to using actual retry count
Summary: build.webkit.org/dashboard: Switch EWS view to using actual retry count
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-29 16:36 PDT by Alexey Proskuryakov
Modified: 2014-09-30 12:48 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch (5.11 KB, patch)
2014-09-29 16:39 PDT, Alexey Proskuryakov
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-09-29 16:36:34 PDT
EWS view on the dashboard displays message count, which is inconsistent with other tools. It is accurate in that this is how many times we tried to test, but displaying completed iterations (which take up to 3 attempts) makes more sense I think.
Comment 1 Alexey Proskuryakov 2014-09-29 16:39:47 PDT
Created attachment 238897 [details]
proposed patch
Comment 2 Ryosuke Niwa 2014-09-30 11:56:33 PDT
Comment on attachment 238897 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238897&action=review

> Tools/QueueStatusServer/app.yaml:2
> -version: 174192 # Bugzilla bug ID of last major change
> +version: ap # Bugzilla bug ID of last major change

Revert?
Comment 3 Alexey Proskuryakov 2014-09-30 12:48:26 PDT
Committed <http://trac.webkit.org/r174115>.