RESOLVED FIXED 137223
EWS is inconclusively spinning forever on a patch that breaks 500+ tests
https://bugs.webkit.org/show_bug.cgi?id=137223
Summary EWS is inconclusively spinning forever on a patch that breaks 500+ tests
Tim Horton
Reported 2014-09-29 12:27:48 PDT
There's no way that EWS shouldn't be able to tell that the patch in https://bugs.webkit.org/show_bug.cgi?id=137164 breaks 500+ tests. But, it can't. See here: https://webkit-queues.appspot.com/patch/238809
Attachments
Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red. (2.41 KB, patch)
2014-10-01 13:15 PDT, Jake Nielsen
no flags
Jake Nielsen
Comment 1 2014-10-01 13:15:51 PDT
Created attachment 239043 [details] Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red.
WebKit Commit Bot
Comment 2 2014-10-01 14:08:22 PDT
Comment on attachment 239043 [details] Adds a check to see whether the tests are hitting the test failure limit. If they are, code execution continues to see whether the tree is also red. Clearing flags on attachment: 239043 Committed r174170: <http://trac.webkit.org/changeset/174170>
WebKit Commit Bot
Comment 3 2014-10-01 14:08:28 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2014-10-01 14:37:21 PDT
With this fix, will we have EWS spew the 500 failures into a Bugzilla comment?
Jake Nielsen
Comment 5 2014-10-01 16:23:13 PDT
Crap, I forgot about that. Let me go check exactly what will happen. (In reply to comment #4) > With this fix, will we have EWS spew the 500 failures into a Bugzilla comment?
Note You need to log in before you can comment on or make changes to this bug.