Bug 137221 – Use is<>() / downcast<>() for Document

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Use is<>() / downcast<>() for Document instead of isDocumentNode() / toDocument(). This is a step towards getting rid of the NODE_TYPE_CASTS() macro.

[Chris Dumez]

Created attachment 238864 [details]
Patch

[WebKit Commit Bot]

Attachment 238864 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.h:1745:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGDocument.h:57:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageDocument.h:87:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/MediaDocument.h:61:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/PluginDocument.h:66:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLDocument.h:102:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 6 in 69 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 238864 [details]
Patch

Attachment 238864 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6601009887444992

New failing tests:
accessibility/container-node-delete-causes-crash.html
accessibility/canvas-description-and-role.html
accessibility/canvas-fallback-content.html
accessibility/first-letter-text-transform-causes-crash.html
accessibility/content-editable-as-textarea.html
accessibility/contenteditable-table-check-causes-crash.html
accessibility/aria-namefrom-author.html
accessibility/accessibility-object-detached.html
compositing/generated-content.html
canvas/philip/tests/2d.composite.globalComposite.html
accessibility/aria-required.html
compositing/absolute-inside-out-of-view-fixed.html
accessibility/aria-inherits-presentational.html
accessibility/help-text.html
accessibility/aria-labelledby-overrides-aria-labeledby.html
accessibility/aria-mappings.html
accessibility/aria-hidden-hides-all-elements.html
accessibility/content-editable-set-inner-text-generates-axvalue-notification.html
accessibility/heading-crash-after-hidden.html
accessibility/aria-setsize-posinset.html
accessibility/heading-level.html
accessibility/duplicate-child-nodes.html
accessibility/aria-hidden-false-works-in-subtrees.html
accessibility/accessibility-node-memory-management.html
compositing/direct-image-compositing.html
accessibility/aria-invalid.html
compositing/clip-child-by-non-stacking-ancestor.html
compositing/compositing-visible-descendant.html
compositing/document-background-color.html

[Build Bot]

Created attachment 238870 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Chris Dumez]

Created attachment 238872 [details]
Patch

[Chris Dumez]

Created attachment 238873 [details]
Patch

[WebKit Commit Bot]

Attachment 238873 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.h:1745:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGDocument.h:57:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageDocument.h:87:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/MediaDocument.h:61:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/PluginDocument.h:66:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLDocument.h:102:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 6 in 68 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 238874 [details]
Patch

[WebKit Commit Bot]

Attachment 238874 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.h:1745:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGDocument.h:57:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageDocument.h:87:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/MediaDocument.h:61:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/PluginDocument.h:66:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLDocument.h:102:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 6 in 68 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 238874 [details]
Patch

Clearing flags on attachment: 238874

Committed r174089: <http://trac.webkit.org/changeset/174089>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.