Bug 137213 - Minor bug in UIClient::exceededDatabaseQuota()
Summary: Minor bug in UIClient::exceededDatabaseQuota()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinyoung Hur
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-29 07:24 PDT by Jinyoung Hur
Modified: 2015-08-31 21:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.92 KB, patch)
2014-09-29 07:50 PDT, Jinyoung Hur 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2014-09-29 18:03 PDT, Jinyoung Hur 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinyoung Hur 2014-09-29 07:24:42 PDT 
completionHandler() should not be called more than once.
Comment 1 Jinyoung Hur 2014-09-29 07:50:38 PDT 
Created attachment 238853 [details]
Patch
Comment 2 Anders Carlsson 2014-09-29 13:12:04 PDT 
Comment on attachment 238853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238853&action=review

> Source/WebKit2/ChangeLog:9
> +        (WKPageSetPageUIClient):

Patch looks great, but please fill in the ChangeLog, saying something like:

"Make sure to not call the completion handler twice if exceededDatabaseQuota is null."
Comment 3 Jinyoung Hur 2014-09-29 18:03:47 PDT 
Created attachment 238898 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-02 01:01:17 PDT 
Comment on attachment 238898 [details]
Patch

Clearing flags on attachment: 238898

Committed r174204: <http://trac.webkit.org/changeset/174204>
Comment 5 WebKit Commit Bot 2014-10-02 01:01:21 PDT 
All reviewed patches have been landed.  Closing bug.