Bug 137193 – [GTK] Move GtkPopupMenu implementation to WebPopupMenuProxyGtk

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

This class was in platform only to have a common implementation to be shared with WebKit1. Now that it's only used by WebPopupMenuProxyGtk in WebKit2, we can simplify the code by merging the implementation directly into WebPopupMenuProxyGtk.

[Carlos Garcia Campos]

Created attachment 238812 [details]
Patch

[WebKit Commit Bot]

Attachment 238812 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:134:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gustavo Noronha (kov)]

Comment on attachment 238812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238812&action=review

LGTM with one question:

> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:-69
> -        m_popup->clear();

Is clearing the menu no longer necessary? I couldn't figure out what change makes this not needed.

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 238812 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238812&action=review
> 
> LGTM with one question:
> 
> > Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:-69
> > -        m_popup->clear();
> 
> Is clearing the menu no longer necessary? I couldn't figure out what change makes this not needed.

Yes, I'm not sure if that was there because WebKit1 worked differently, but in WebKit2, the same WebPopupMenuProxy can't be populated twice, the page proxy always creates a new WebPopupMenuProxy when it receives the ShowPopupMenu message and if there was an active one already, it's destroyed.

[Carlos Garcia Campos]

Committed r174103: <http://trac.webkit.org/changeset/174103>