WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137181
Implement op_profile_type in the 32-bit baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=137181
Summary
Implement op_profile_type in the 32-bit baseline JIT
Saam Barati
Reported
2014-09-27 12:41:11 PDT
Currently, the 32-bit version of op_profile_type just jumps to the slow path. Have it emit inline assembly for writing to TypeProfilerLog.
Attachments
patch
(4.77 KB, patch)
2014-10-03 14:05 PDT
,
Saam Barati
msaboff
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2014-10-03 14:05:33 PDT
Created
attachment 239232
[details]
patch
Michael Saboff
Comment 2
2014-10-03 14:28:07 PDT
Comment on
attachment 239232
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=239232&action=review
r=me
> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1350 > + Jump skipClearLog = branchPtr(NotEqual, regT1, TrustedImmPtr(cachedTypeProfilerLog->logEndPtr()));
This could be jumpToEnd.append(branchPtr(....)) to simplify the logic.
Saam Barati
Comment 3
2014-10-03 15:20:31 PDT
landed in:
http://trac.webkit.org/changeset/174298
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug