Bug 137181 - Implement op_profile_type in the 32-bit baseline JIT
Summary: Implement op_profile_type in the 32-bit baseline JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-27 12:41 PDT by Saam Barati
Modified: 2014-10-03 15:20 PDT (History)
2 users (show)

See Also:

Attachments
patch (4.77 KB, patch)
2014-10-03 14:05 PDT, Saam Barati 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2014-09-27 12:41:11 PDT 
Currently, the 32-bit version of op_profile_type just jumps to the slow path. Have it emit inline assembly for writing to TypeProfilerLog.
Comment 1 Saam Barati 2014-10-03 14:05:33 PDT 
Created attachment 239232 [details]
patch
Comment 2 Michael Saboff 2014-10-03 14:28:07 PDT 
Comment on attachment 239232 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239232&action=review

r=me

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:1350
> +    Jump skipClearLog = branchPtr(NotEqual, regT1, TrustedImmPtr(cachedTypeProfilerLog->logEndPtr()));

This could be jumpToEnd.append(branchPtr(....)) to simplify the logic.
Comment 3 Saam Barati 2014-10-03 15:20:31 PDT 
landed in: http://trac.webkit.org/changeset/174298