Bug 137167 - Disable function.arguments
Summary: Disable function.arguments
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2014-09-26 20:09 PDT by Filip Pizlo
Modified: 2016-07-20 07:17 PDT (History)
13 users (show)

See Also:

patch for landing (16.36 KB, patch)
2014-09-26 20:13 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-09-26 20:09:22 PDT
This disables function.arguments, but leaves the infrastructure to support it.  We'll give it a while before we rip out that infrastructure.

While the infrastructure is in the tree, you can enable it by setting JSC_enableFunctionDotArguments=true.  It's also enabled for running JavaScriptCore stress tests.
Comment 1 Filip Pizlo 2014-09-26 20:13:58 PDT
Created attachment 238756 [details]
patch for landing

Comment 2 Filip Pizlo 2014-09-27 13:28:35 PDT
Landed in http://trac.webkit.org/changeset/174036
Comment 3 Csaba Osztrogonác 2016-07-20 07:06:51 PDT
(In reply to comment #2)
> Landed in http://trac.webkit.org/changeset/174036

http://trac.webkit.org/changeset/177029 reenabled function.arguments
20 moths ago. Do we still need this code path?
Comment 4 Csaba Osztrogonác 2016-07-20 07:17:14 PDT
And --useFunctionDotArguments=true is passed to all tests in RJST script
when this option is always true 20 months ago. It seems to be redundant.