Replace OSObjectPtr with RetainPtr/adoptOS
Created attachment 238740 [details]
Comment on attachment 238740 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=238740&action=review
> + in that unlike adoptCF(), it can be passed an objective-c type (since OS objects
> + are sometimes objective-c objects, but not always), and unlike adoptNS() it doesn't
> + require us to jump through hoops to appease GC (since OS objects are not objective-c
Fixed in https://trac.webkit.org/r174045 .
Looks like this patch introduced a PLT3 crasher in Yosemite :( See <rdar://problem/18487776>.
Re-opened since this is blocked by bug 137231
(In reply to comment #5)
> Re-opened since this is blocked by bug 137231
Scrapping this for now. In 32-bit, OS Objects are not objective-c objects, but also not CFObjects, so they can't be CFRetain()/CFReleased(). I think we are going to need to stick with OSObjectPtr for now.