WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
137158
Replace OSObjectPtr with RetainPtr/adoptOS
https://bugs.webkit.org/show_bug.cgi?id=137158
Summary
Replace OSObjectPtr with RetainPtr/adoptOS
Sam Weinig
Reported
2014-09-26 14:47:29 PDT
Replace OSObjectPtr with RetainPtr/adoptOS
Attachments
Patch
(39.11 KB, patch)
2014-09-26 14:52 PDT
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-09-26 14:52:24 PDT
Created
attachment 238740
[details]
Patch
mitz
Comment 2
2014-09-26 16:24:07 PDT
Comment on
attachment 238740
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=238740&action=review
> Source/WTF/ChangeLog:15 > + in that unlike adoptCF(), it can be passed an objective-c type (since OS objects > + are sometimes objective-c objects, but not always), and unlike adoptNS() it doesn't > + require us to jump through hoops to appease GC (since OS objects are not objective-c
Objective-C
Sam Weinig
Comment 3
2014-09-28 14:00:20 PDT
Fixed in
https://trac.webkit.org/r174045
.
Ryosuke Niwa
Comment 4
2014-09-29 09:46:56 PDT
Looks like this patch introduced a PLT3 crasher in Yosemite :( See <
rdar://problem/18487776
>.
WebKit Commit Bot
Comment 5
2014-09-29 14:23:10 PDT
Re-opened since this is blocked by
bug 137231
Sam Weinig
Comment 6
2014-10-03 17:39:32 PDT
(In reply to
comment #5
)
> Re-opened since this is blocked by
bug 137231
Scrapping this for now. In 32-bit, OS Objects are not objective-c objects, but also not CFObjects, so they can't be CFRetain()/CFReleased(). I think we are going to need to stick with OSObjectPtr for now.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug