Web Inspector: Type Token View shows type information on hover when it shouldn't

[Saam Barati]

TypeTokenView::_shouldShowPopover is broken:

One of its conditions reads: 
if (this._types.structures && this._types.structures) { ... }

But it should be written as:
if (this._types.structures && this._types.structures.length > 1) { ... }

[Radar WebKit Bug Importer]

<rdar://problem/18470483>

[Saam Barati]

(In reply to comment #0)
> TypeTokenView::_shouldShowPopover is broken:
> 
> One of its conditions reads: 
> if (this._types.structures && this._types.structures) { ... }
> 
> But it should be written as:
> if (this._types.structures && this._types.structures.length > 1) { ... }
This should actually be:
 if (this._types.structures && this._types.structures.length >= 1) { ... }
because we care if there is only one object or more, not more than one.

[Saam Barati]

Created attachment 238737 [details]
patch

[Brian Burg]

Comment on attachment 238737 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238737&action=review

> Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js:135
> +        if (this._types.structures && this._types.structures.length >= 1)

I think you can drop the >= 1 here.

[Saam Barati]

landed in: http://trac.webkit.org/changeset/174019