RESOLVED FIXED 137152
Web Inspector: Type Token View shows type information on hover when it shouldn't 
https://bugs.webkit.org/show_bug.cgi?id=137152
Summary Web Inspector: Type Token View shows type information on hover when it shouldn't
Saam Barati
Reported 2014-09-26 10:56:49 PDT
TypeTokenView::_shouldShowPopover is broken: One of its conditions reads: if (this._types.structures && this._types.structures) { ... } But it should be written as: if (this._types.structures && this._types.structures.length > 1) { ... }
Attachments
patch (1.53 KB, patch)
2014-09-26 14:22 PDT, Saam Barati 		burg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-09-26 10:57:02 PDT
<rdar://problem/18470483>
Saam Barati
Comment 2 2014-09-26 14:16:47 PDT
(In reply to comment #0) > TypeTokenView::_shouldShowPopover is broken: > > One of its conditions reads: > if (this._types.structures && this._types.structures) { ... } > > But it should be written as: > if (this._types.structures && this._types.structures.length > 1) { ... } This should actually be: if (this._types.structures && this._types.structures.length >= 1) { ... } because we care if there is only one object or more, not more than one.
Saam Barati
Comment 3 2014-09-26 14:22:19 PDT
Created attachment 238737 [details] patch
Brian Burg
Comment 4 2014-09-26 14:25:16 PDT
Comment on attachment 238737 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=238737&action=review > Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js:135 > + if (this._types.structures && this._types.structures.length >= 1) I think you can drop the >= 1 here.
Saam Barati
Comment 5 2014-09-26 14:40:31 PDT
landed in: http://trac.webkit.org/changeset/174019
Note You need to log in before you can comment on or make changes to this bug.