Bug 137149 - Mark fast/selectors/nth-child-of-basics as Slow
Summary: Mark fast/selectors/nth-child-of-basics as Slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-26 09:57 PDT by Yusuke Suzuki
Modified: 2014-09-26 20:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2014-09-26 10:02 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2014-09-26 09:57:35 PDT 
fast/selectors/nth-child-of-basics takes long time
Comment 1 Yusuke Suzuki 2014-09-26 10:02:01 PDT 
Created attachment 238723 [details]
Patch
Comment 2 Yusuke Suzuki 2014-09-26 10:07:04 PDT 
Comment on attachment 238723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238723&action=review

> LayoutTests/ChangeLog:11
> +        [1]: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)/builds/3042

Actually, in my environment  (GTK debug build), it takes about 50s and ran as expected.
Is it better to split it into small tests that meet the timeout limit?
Comment 3 Benjamin Poulain 2014-09-26 12:24:43 PDT 
(In reply to comment #2)
> (From update of attachment 238723 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=238723&action=review
> 
> > LayoutTests/ChangeLog:11
> > +        [1]: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)/builds/3042
> 
> Actually, in my environment  (GTK debug build), it takes about 50s and ran as expected.
> Is it better to split it into small tests that meet the timeout limit?

I'll start on the JIT for it soon, maybe today.

Let's mark it slow for now and I'll remove the expectation next week.
Comment 4 WebKit Commit Bot 2014-09-26 20:52:58 PDT 
Comment on attachment 238723 [details]
Patch

Clearing flags on attachment: 238723

Committed r174032: <http://trac.webkit.org/changeset/174032>
Comment 5 WebKit Commit Bot 2014-09-26 20:53:00 PDT 
All reviewed patches have been landed.  Closing bug.