Bug 137148 – [GTK] Don't include full path names in WebKitEnumTypes.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alberto Garcia]

In short, we should replace @filename@ with @basename@ here:

/*** BEGIN file-production ***/
/* Enumerations from @filename@. */
/*** END file-production ***/

The former puts the full path of the compilation directory in the generated file,
which should not be there, which among other things makes it more difficult to
have a multiarch-compliant header.

[Alberto Garcia]

Created attachment 238722 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

(In reply to comment #0)
> In short, we should replace @filename@ with @basename@ here:
> 
> /*** BEGIN file-production ***/
> /* Enumerations from @filename@. */
> /*** END file-production ***/
> 
> The former puts the full path of the compilation directory in the generated file,
> which should not be there, which among other things makes it more difficult to
> have a multiarch-compliant header.

How does affect that multi-arch if it's just a comment?

[Alberto Garcia]

(In reply to comment #3)
> How does affect that multi-arch if it's just a comment?

Multi-arch requires that all architecture-independent files are
identical among different architectures.

This file is architecture-indepent however it will be different among
builds if those builds are made in different directories.

[Carlos Garcia Campos]

(In reply to comment #4)
> (In reply to comment #3)
> > How does affect that multi-arch if it's just a comment?
> 
> Multi-arch requires that all architecture-independent files are
> identical among different architectures.
> 
> This file is architecture-indepent however it will be different among
> builds if those builds are made in different directories.

Ah, I see, thanks!

[Alberto Garcia]

Committed r174008: <http://trac.webkit.org/changeset/174008>