In short, we should replace @filename@ with @basename@ here: /*** BEGIN file-production ***/ /* Enumerations from @filename@. */ /*** END file-production ***/ The former puts the full path of the compilation directory in the generated file, which should not be there, which among other things makes it more difficult to have a multiarch-compliant header.
Created attachment 238722 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
(In reply to comment #0) > In short, we should replace @filename@ with @basename@ here: > > /*** BEGIN file-production ***/ > /* Enumerations from @filename@. */ > /*** END file-production ***/ > > The former puts the full path of the compilation directory in the generated file, > which should not be there, which among other things makes it more difficult to > have a multiarch-compliant header. How does affect that multi-arch if it's just a comment?
(In reply to comment #3) > How does affect that multi-arch if it's just a comment? Multi-arch requires that all architecture-independent files are identical among different architectures. This file is architecture-indepent however it will be different among builds if those builds are made in different directories.
(In reply to comment #4) > (In reply to comment #3) > > How does affect that multi-arch if it's just a comment? > > Multi-arch requires that all architecture-independent files are > identical among different architectures. > > This file is architecture-indepent however it will be different among > builds if those builds are made in different directories. Ah, I see, thanks!
Committed r174008: <http://trac.webkit.org/changeset/174008>