Bug 137120 - [EME] Pass location for media key storage through from WebKit/WebKit2.
Summary: [EME] Pass location for media key storage through from WebKit/WebKit2.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 137993
Blocks: 138147
  Show dependency tree / graph
 
Reported: 2014-09-25 11:51 PDT by Jer Noble
Modified: 2022-08-08 16:08 PDT (History)
12 users (show)

See Also:

Attachments
Patch (39.59 KB, patch)
2014-09-25 14:27 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (41.54 KB, patch)
2014-10-17 14:55 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (37.86 KB, patch)
2014-10-22 20:20 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (40.09 KB, patch)
2014-10-28 12:39 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (40.40 KB, patch)
2014-10-28 12:50 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (40.21 KB, patch)
2014-10-28 13:10 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (41.56 KB, patch)
2014-10-28 14:07 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-09-25 11:51:14 PDT 
[EME] Pass location for media key storage through from WebKit/WebKit2.
Comment 1 Jer Noble 2014-09-25 14:27:16 PDT 
Created attachment 238672 [details]
Patch
Comment 2 Jer Noble 2014-10-17 14:55:18 PDT 
Created attachment 240042 [details]
Patch
Comment 3 Jer Noble 2014-10-22 20:20:33 PDT 
Created attachment 240324 [details]
Patch
Comment 4 Jer Noble 2014-10-28 12:39:49 PDT 
Created attachment 240562 [details]
Patch
Comment 5 Jer Noble 2014-10-28 12:50:06 PDT 
Created attachment 240563 [details]
Patch
Comment 6 Jer Noble 2014-10-28 13:10:27 PDT 
Created attachment 240567 [details]
Patch

Fix the EFL build by removing an unused reference to AsyncTask.h.
Comment 7 Anders Carlsson 2014-10-28 13:54:52 PDT 
Comment on attachment 240567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240567&action=review

> Source/WebKit2/WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:65
> +    for (auto& originPath : originPaths) {

This can probably be const auto&

> Source/WebKit2/WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:120
> +    for (auto& originPath : originPaths)

const auto&.
Comment 8 Jer Noble 2014-10-28 14:07:03 PDT 
Created attachment 240570 [details]
Patch for landing

Added WebMediaKeyStorageManager to the EFL and GTK makefiles.
Comment 9 WebKit Commit Bot 2014-10-28 17:18:09 PDT 
Comment on attachment 240570 [details]
Patch for landing

Clearing flags on attachment: 240570

Committed r175288: <http://trac.webkit.org/changeset/175288>
Comment 10 Radar WebKit Bug Importer 2014-10-29 17:48:56 PDT 
<rdar://problem/18819570>
Comment 11 Ahmad Saleem 2022-08-08 16:08:26 PDT 
From Comment 09, I can see this landing and also from Github that it was not backed out.

Commit - https://github.com/WebKit/WebKit/commit/f990a24f94581cc2c4e16488a4287e3a2bbba059

I am going to mark this as "RESOLVED FIXED". Thanks!