Bug 137119 - [Mac] MediaPlayerPrivateQTKit should not use FrameView
Summary: [Mac] MediaPlayerPrivateQTKit should not use FrameView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on: 137217
Blocks: 21562
  Show dependency tree / graph
 
Reported: 2014-09-25 11:28 PDT by Carlos Garcia Campos
Modified: 2014-09-30 07:30 PDT (History)
7 users (show)

See Also:

Attachments
Proposed patch. (13.44 KB, patch)
2014-09-29 20:12 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-09-25 11:28:11 PDT 
It's a layering violation. There are two cases where frame view is used in code that could be removed:

 - Frame rate rendering, this is not built by default and can be removed.
 - To make the QTMovieView a subview of the document view. This is compiled by default, but can be removed as well.
Comment 1 Eric Carlson 2014-09-29 20:12:20 PDT 
Created attachment 238904 [details]
Proposed patch.
Comment 2 Carlos Garcia Campos 2014-09-29 23:12:00 PDT 
Comment on attachment 238904 [details]
Proposed patch.

More dead code removed :-) Thanks!
Comment 3 WebKit Commit Bot 2014-09-30 07:30:37 PDT 
Comment on attachment 238904 [details]
Proposed patch.

Clearing flags on attachment: 238904

Committed r174106: <http://trac.webkit.org/changeset/174106>
Comment 4 WebKit Commit Bot 2014-09-30 07:30:41 PDT 
All reviewed patches have been landed.  Closing bug.