Bug 137106 - Stop using legacy NODE_TYPE_CASTS() macro in svg/
Summary: Stop using legacy NODE_TYPE_CASTS() macro in svg/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-24 22:28 PDT by Chris Dumez
Modified: 2014-09-25 10:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (45.30 KB, patch)
2014-09-24 23:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-09-24 22:28:33 PDT 
Stop using legacy NODE_TYPE_CAST() in svg/ and use the new SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() / downcast<>() can be used for those types.
Comment 1 Chris Dumez 2014-09-24 23:42:27 PDT 
Created attachment 238644 [details]
Patch
Comment 2 WebKit Commit Bot 2014-09-24 23:44:30 PDT 
Attachment 238644 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/animation/SVGSMILElement.h:242:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGGraphicsElement.h:87:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGPolyElement.h:67:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGAnimateElement.h:83:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGTextContentElement.h:124:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h:87:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 6 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-09-25 10:25:50 PDT 
Comment on attachment 238644 [details]
Patch

Clearing flags on attachment: 238644

Committed r173970: <http://trac.webkit.org/changeset/173970>
Comment 4 WebKit Commit Bot 2014-09-25 10:25:55 PDT 
All reviewed patches have been landed.  Closing bug.