Bug 137105 - [WebKit2] Fix build warning in WebKit2/WebProcess module
Summary: [WebKit2] Fix build warning in WebKit2/WebProcess module
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-24 22:20 PDT by Shivakumar J M
Modified: 2014-09-25 03:51 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.33 KB, patch)
2014-09-24 22:27 PDT, Shivakumar J M 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shivakumar J M 2014-09-24 22:20:54 PDT 
Getting below build warning error when built on latest WK2-EFL port.

In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp:27:0:
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter]
     void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { close(); }
          ^
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageName’ [-Wunused-parameter]
In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp:27:0:
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter]
     void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { closeWindow(); }
          ^
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageName’ [-Wunused-parameter]
[ 90%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPageGroupProxy.cpp.o
[ 90%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/VisitedLinkTableController.cpp.o
In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:80:0:
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter]
     void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { close(); }
          ^
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspector.h:57:10: warning: unused parameter ‘messageName’ [-Wunused-parameter]
In file included from /home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:83:0:
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageReceiverName’ [-Wunused-parameter]
     void didReceiveInvalidMessage(IPC::Connection*, IPC::StringReference messageReceiverName, IPC::StringReference messageName) { closeWindow(); }
          ^
/home/shiva.jm/webkit-git/svngitjun13/WebKit/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.h:52:10: warning: unused parameter ‘messageName’ [-Wunused-parameter]
Comment 1 Shivakumar J M 2014-09-24 22:27:18 PDT 
Created attachment 238642 [details]
Patch

Fix build warning by removing unused parameter names
Comment 2 WebKit Commit Bot 2014-09-25 03:51:35 PDT 
Comment on attachment 238642 [details]
Patch

Clearing flags on attachment: 238642

Committed r173951: <http://trac.webkit.org/changeset/173951>
Comment 3 WebKit Commit Bot 2014-09-25 03:51:40 PDT 
All reviewed patches have been landed.  Closing bug.