Bug 137101 - [iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized
Summary: [iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthor...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2014-09-24 18:45 PDT by Daniel Bates
Modified: 2014-09-24 19:17 PDT (History)
3 users (show)

See Also:

Patch (2.16 KB, patch)
2014-09-24 18:46 PDT, Daniel Bates
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-09-24 18:45:11 PDT
To satisfy clang, add case statement for kCLAuthorizationStatusAuthorized in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization], <http://trac.webkit.org/browser/trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm?rev=168555#L95> and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:, <http://trac.webkit.org/browser/trunk/Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm?rev=168555#L149>.
Comment 1 Daniel Bates 2014-09-24 18:46:28 PDT
Created attachment 238635 [details]
Comment 2 Mark Lam 2014-09-24 18:56:21 PDT
Comment on attachment 238635 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=238635&action=review

r=me with indentation fix.

> Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm:114
> +        case kCLAuthorizationStatusAuthorized:

Please fix this indentation.
Comment 3 Daniel Bates 2014-09-24 19:15:18 PDT
Comment 4 Daniel Bates 2014-09-24 19:17:42 PDT
Committed r173940: <http://trac.webkit.org/changeset/173940>